Re: [PATCH v12 2/5] clk: clocking-wizard: Add the clockwizard to clk directory

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Shubhrajyoti,

Thanks for your patch!

On Tue, Aug 10, 2021 at 10:37 AM Shubhrajyoti Datta
<shubhrajyoti.datta@xilinx.com> wrote:
> Add clocking wizard driver to clk.
> And delete the driver from the staging as it is in drivers/clk.

The old driver is not deleted from staging?

>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
>
>  drivers/clk/Kconfig                 |   9 +
>  drivers/clk/Makefile                |   1 +
>  drivers/clk/clk-xlnx-clock-wizard.c | 635 ++++++++++++++++++++++++++++
>  3 files changed, 645 insertions(+)
>  create mode 100644 drivers/clk/clk-xlnx-clock-wizard.c
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index e873f9ea2e65..22817be89bd8 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -390,6 +390,15 @@ config COMMON_CLK_K210
>         help
>           Support for the Canaan Kendryte K210 RISC-V SoC clocks.
>
> +config COMMON_CLK_XLNX_CLKWZRD
> +       tristate "Xilinx Clocking Wizard"
> +       depends on COMMON_CLK && OF

Should there be a platform dependency ("depends on <FOO> ||
COMPILE_TEST"), to avoid asking the user about this driver when
configuring a kernel for a platform that does not have this device,
or can this device be present on any platform?

Despite the original driver having been added 7 years ago, there are
no upstream users of "xlnx,clocking-wizard" yet...

> +       help
> +         Support for the Xilinx Clocking Wizard IP core clock generator.
> +         Adds support for clocking wizard and compatible.
> +         This driver supports the Xilinx clocking wizard programmable clock
> +         synthesizer. The number of output is configurable in the design.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds