Re: [PATCH 02/15] dt-bindings: clock: Add R8A779H0 V4M CPG Core Clock Definitions

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Krzysztof,

On Tue, Jan 9, 2024 at 8:21 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 08/01/2024 16:33, Geert Uytterhoeven wrote:
> > From: Duy Nguyen <duy.nguyen.rh@renesas.com>
> >
> > Add all Clock Pulse Generator Core Clock Outputs for the Renesas R-Car
> > V4M (R8A779H0) SoC.
> >
> > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
> > Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Changes compared to the BSP:
> >   - Drop POST* clocks, as they are internal clocks.
> > ---
> >  include/dt-bindings/clock/r8a779h0-cpg-mssr.h | 96 +++++++++++++++++++
>
> Mediatek was able to switch to vendor,device naming scheme, so Renesas
> should follow as well.

For new bindings, or also for existing ones?
Doing the former means there are inconsistencies among different SoCs
in the same family.
Doing the latter requires keeping the existing header files as wrappers
including the new header files, because the binding definitions are
part of the stable DT API.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds