devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 02/16] dt-bindings: arm: renesas: Document Renesas Spider boards
Date: Thu, 18 Nov 2021 18:53:55 +0100	[thread overview]
Message-ID: <CAMuHMdUK5gaBh0O5kmOpB+YN6S6OsLSC_J_KmmSMxRTtu6LPNg@mail.gmail.com> (raw)
In-Reply-To: <20211116074130.107554-3-yoshihiro.shimoda.uh@renesas.com>

Hi Shimoda-san,

On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add device tree bindings documentation for Renesas R-Car S4-8
> Spider CPU and BreakOut boards.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -317,6 +317,14 @@ properties:
>
>        - description: R-Car S4-8 (R8A779F0)
>          items:
> +          - enum:
> +              - renesas,spider-cpu # Spider CPU board (RTP8A779FASKB0SC2S)
> +          - const: renesas,r8a779f0
> +
> +        items:

Missing "-" in front of "items:".

> +          - enum:
> +              - renesas,spider-breakout # Spider BreakOut board (RTP8A779F0ASKB0SB0S)
> +          - const: renesas,spider-cpu
>            - const: renesas,r8a779f0
>
>        - description: R-Car H3e (R8A779M0)

The rest LGTM.
Reading[1], I assume "RTP8A779F0ASKB0SP2S" is the part number of the
full kit?

[1] https://www.renesas.com/us/en/products/automotive-products/automotive-system-chips-socs/rtp8a779f0askb0sp2s-r-car-s4-reference-boardspider

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2021-11-18 17:54 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  7:41 [PATCH 00/16] treewide: Initial support for R-Car S4-8 Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 01/16] dt-bindings: arm: renesas: Document R-Car S4-8 SoC DT bindings Yoshihiro Shimoda
2021-11-18 17:50   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 02/16] dt-bindings: arm: renesas: Document Renesas Spider boards Yoshihiro Shimoda
2021-11-16 14:02   ` Rob Herring
2021-11-18 17:53   ` Geert Uytterhoeven [this message]
2021-11-19  2:14     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 03/16] dt-bindings: reset: renesas,rst: Document r8a779f0 reset module Yoshihiro Shimoda
2021-11-18 18:19   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 04/16] dt-bindings: power: renesas,rcar-sysc: Document r8a779f0 SYSC bindings Yoshihiro Shimoda
2021-11-18 18:38   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 05/16] dt-bindings: power: Add r8a779f0 SYSC power domain definitions Yoshihiro Shimoda
2021-11-18 18:42   ` Geert Uytterhoeven
2021-11-19  2:16     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 06/16] dt-bindings: clock: renesas,cpg-mssr: Document r8a779f0 Yoshihiro Shimoda
2021-11-18 18:43   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 07/16] dt-bindings: clock: Add r8a779f0 CPG Core Clock Definitions Yoshihiro Shimoda
2021-11-18 18:53   ` Geert Uytterhoeven
2021-11-19  2:21     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 08/16] dt-bindings: serial: renesas,scif: Document r8a779f0 bindings Yoshihiro Shimoda
2021-11-18 18:56   ` Geert Uytterhoeven
2021-11-19  2:24     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 09/16] soc: renesas: Identify R-Car S4-8 Yoshihiro Shimoda
2021-11-18 19:03   ` Geert Uytterhoeven
2021-11-19  2:27     ` Yoshihiro Shimoda
2021-11-18 19:04   ` Geert Uytterhoeven
2021-11-19  2:32     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 10/16] soc: renesas: r8a779f0-sysc: Add r8a779f0 support Yoshihiro Shimoda
2021-11-23 16:18   ` Geert Uytterhoeven
2021-11-24  6:49     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 11/16] soc: renesas: rcar-rst: Add support for R-Car S4-8 Yoshihiro Shimoda
2021-11-18 19:10   ` Geert Uytterhoeven
2021-11-19  2:35     ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 12/16] clk: renesas: cpg-mssr: " Yoshihiro Shimoda
2021-11-24 13:48   ` Geert Uytterhoeven
2021-11-29  8:35     ` Yoshihiro Shimoda
2021-11-29  8:47       ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 13/16] tty: serial: sh-sci: Add support for R-Car Gen4 Yoshihiro Shimoda
2021-11-18 19:11   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 14/16] arm64: dts: renesas: Add Renesas R8A779F0 SoC support Yoshihiro Shimoda
2021-11-24 14:02   ` Geert Uytterhoeven
2021-11-16  7:41 ` [PATCH 15/16] arm64: dts: renesas: Add Renesas Spider boards support Yoshihiro Shimoda
2021-11-24 14:06   ` Geert Uytterhoeven
2021-12-08  9:21     ` Geert Uytterhoeven
2021-12-08  9:36       ` Yoshihiro Shimoda
2021-11-16  7:41 ` [PATCH 16/16] arm64: defconfig: Enable R-Car S4-8 Yoshihiro Shimoda
2021-11-24 14:03   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUK5gaBh0O5kmOpB+YN6S6OsLSC_J_KmmSMxRTtu6LPNg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).