devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: renesas: falcon: Wire-up Ethernet breakout board
@ 2024-10-22 18:47 Niklas Söderlund
  2024-10-22 18:47 ` [PATCH 1/2] arm64: dts: renesas: r8a779a0: Remove address- and size-cells from AVB[1-5] Niklas Söderlund
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Niklas Söderlund @ 2024-10-22 18:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-renesas-soc, devicetree
  Cc: Niklas Söderlund

Hi Geert,

This small series wires up the Marvell 88Q2110 PHYs found on the Falcon 
Ethernet breakout board. With this applied all five PHYs are probed 
correctly.

    mv88q2110 e6810000.ethernet-ffffffff:07: attached PHY driver (mii_bus:phy_addr=e6810000.ethernet-ffffffff:07, irq=POLL)
    mv88q2110 e6820000.ethernet-ffffffff:07: attached PHY driver (mii_bus:phy_addr=e6820000.ethernet-ffffffff:07, irq=POLL)
    mv88q2110 e6830000.ethernet-ffffffff:07: attached PHY driver (mii_bus:phy_addr=e6830000.ethernet-ffffffff:07, irq=POLL)
    mv88q2110 e6840000.ethernet-ffffffff:07: attached PHY driver (mii_bus:phy_addr=e6840000.ethernet-ffffffff:07, irq=POLL)
    mv88q2110 e6850000.ethernet-ffffffff:07: attached PHY driver (mii_bus:phy_addr=e6850000.ethernet-ffffffff:07, irq=POLL)

They can be auto detected with just the compatible 
"ethernet-phy-ieee802.3-c45", but to keep the style currently used I 
have added the specific compatible for the 88Q2110 as done for other 
SoCs.

The primary issue we had with this in the past was due to an incorrect  
PHY address. After studying the schematics (v100) I found the PHYs 
address pins are wired differently on Falcon compared to other Gen4 
boards. On Falcon they are pulled-down, while on other Gen4 boards they 
are left unconnected and subjected to the PHYs internal pull-ups. This 
gives the PHY an address where the lower 3 bits of the address is 
inverted for Falcon.

Patch 1/2 is a simple preparation patch removing properties that should 
not be set in the base SoC include and will produce warnings once the 
mdio node is added. Patch 2/2 wires up the PHYs.

Most likely the change in 1/2 should be applied to AVB0 also, but 
pending our discussion in a different patch about where to place the 
reset-gpio property for mdio nodes that don't strictly need it I left 
AVB0 as is.

Niklas Söderlund (2):
  arm64: dts: renesas: r8a779a0: Remove address- and size-cells from
    AVB[1-5]
  arm64: dts: renesas: falcon: ethernet: Describe PHYs connected on the
    breakout board

 .../dts/renesas/r8a779a0-falcon-ethernet.dtsi | 248 ++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779a0.dtsi     |  10 -
 2 files changed, 248 insertions(+), 10 deletions(-)

-- 
2.46.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-10-23 12:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 18:47 [PATCH 0/2] arm64: dts: renesas: falcon: Wire-up Ethernet breakout board Niklas Söderlund
2024-10-22 18:47 ` [PATCH 1/2] arm64: dts: renesas: r8a779a0: Remove address- and size-cells from AVB[1-5] Niklas Söderlund
2024-10-22 18:47 ` [PATCH 2/2] arm64: dts: renesas: falcon: ethernet: Describe PHYs connected on the breakout board Niklas Söderlund
2024-10-23  7:13 ` [PATCH 0/2] arm64: dts: renesas: falcon: Wire-up Ethernet " Geert Uytterhoeven
2024-10-23  7:35   ` Wolfram Sang
2024-10-23  7:37     ` Geert Uytterhoeven
2024-10-23 12:41   ` Niklas Söderlund
2024-10-23 12:43     ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).