[PATCH v3 0/3] dmaengine: sh: rz-dmac: add r7s72100 support

[PATCH v3 0/3] dmaengine: sh: rz-dmac: add r7s72100 support

[Wolfram Sang]

Changes since v2:
* added tags to patches 1 and 3
* reword commit message 2 to make clear 'clocks' are not needed
* 'power-domains' is also not required for RZA1

Thanks to Geert for the tags and for the input!

Trimmed down initial cover-letter:

When activating good old Genmai board for regression testing, I found
out that not much is needed to activate the DMA controller for A1H.

Patch 1 is a generic fix. The other patches are the actual enablement.
A branch with DTS additions for MMCIF can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/genmai-upstreaming

These will be upstreamed once the driver parts are in next.

Wolfram Sang (3):
  dmaengine: sh: rz-dmac: handle configs where one address is zero
  dt-bindings: dma: rz-dmac: Document RZ/A1H SoC
  dmaengine: sh: rz-dmac: add r7s72100 support

 .../bindings/dma/renesas,rz-dmac.yaml         | 29 +++++++++++++------
 drivers/dma/sh/Kconfig                        |  8 ++---
 drivers/dma/sh/rz-dmac.c                      | 27 +++++++++--------
 3 files changed, 39 insertions(+), 25 deletions(-)

-- 
2.45.2

[PATCH v3 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1H SoC

[Wolfram Sang]

Document the Renesas RZ/A1H DMAC block. This one does not have clocks,
resets and power domains. Update the bindings accordingly. Introduce a
generic name in the header to make future additions easier.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 .../bindings/dma/renesas,rz-dmac.yaml         | 29 +++++++++++++------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
index ca24cf48769f..b356251de5a8 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
@@ -4,18 +4,16 @@
 $id: http://devicetree.org/schemas/dma/renesas,rz-dmac.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Renesas RZ/{G2L,G2UL,V2L} DMA Controller
+title: Renesas RZ DMA Controller
 
 maintainers:
   - Biju Das <biju.das.jz@bp.renesas.com>
 
-allOf:
-  - $ref: dma-controller.yaml#
-
 properties:
   compatible:
     items:
       - enum:
+          - renesas,r7s72100-dmac # RZ/A1H
           - renesas,r9a07g043-dmac # RZ/G2UL and RZ/Five
           - renesas,r9a07g044-dmac # RZ/G2{L,LC}
           - renesas,r9a07g054-dmac # RZ/V2L
@@ -93,13 +91,26 @@ required:
   - reg
   - interrupts
   - interrupt-names
-  - clocks
-  - clock-names
   - '#dma-cells'
   - dma-channels
-  - power-domains
-  - resets
-  - reset-names
+
+allOf:
+  - $ref: dma-controller.yaml#
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - renesas,r7s72100-dmac
+    then:
+      required:
+        - clocks
+        - clock-names
+        - power-domains
+        - resets
+        - reset-names
 
 additionalProperties: false
 
-- 
2.45.2

Re: [PATCH v3 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1H SoC

[Geert Uytterhoeven]

On Mon, Oct 7, 2024 at 1:02 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Document the Renesas RZ/A1H DMAC block. This one does not have clocks,
> resets and power domains. Update the bindings accordingly. Introduce a
> generic name in the header to make future additions easier.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1H SoC

[Rob Herring (Arm)]

On Mon, 07 Oct 2024 13:02:02 +0200, Wolfram Sang wrote:
> Document the Renesas RZ/A1H DMAC block. This one does not have clocks,
> resets and power domains. Update the bindings accordingly. Introduce a
> generic name in the header to make future additions easier.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  .../bindings/dma/renesas,rz-dmac.yaml         | 29 +++++++++++++------
>  1 file changed, 20 insertions(+), 9 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: (subset) [PATCH v3 0/3] dmaengine: sh: rz-dmac: add r7s72100 support

[Vinod Koul]

On Mon, 07 Oct 2024 13:02:00 +0200, Wolfram Sang wrote:
> Changes since v2:
> * added tags to patches 1 and 3
> * reword commit message 2 to make clear 'clocks' are not needed
> * 'power-domains' is also not required for RZA1
> 
> Thanks to Geert for the tags and for the input!
> 
> [...]

Applied, thanks!

[2/3] dt-bindings: dma: rz-dmac: Document RZ/A1H SoC
      commit: 209efec19c4c0cea17ff01d67c8fbd75a90fb854
[3/3] dmaengine: sh: rz-dmac: add r7s72100 support
      commit: 32172b3e3265833a367e41842fa8b7eaa0acae96

Best regards,
-- 
~Vinod