devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys
Date: Mon, 30 Sep 2024 16:29:09 +0200	[thread overview]
Message-ID: <CAMuHMdUMGm2nbwC-8Z3yw365PPeDf1eB5Lc6zLVoZ7GauT_R_A@mail.gmail.com> (raw)
In-Reply-To: <20240927095414.10241-8-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> @@ -67,8 +67,7 @@ keyboard {
>
>                 key-1 {
>                         /* JP3 must be set to 1-2 (default) */
> -                       interrupt-parent = <&irqc>;
> -                       interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
> +                       interrupts-extended = <&irqc 6 IRQ_TYPE_EDGE_BOTH>;
>                         linux,code = <KEY_1>;
>                         label = "SW6,SW7";
>                         wakeup-source;

Given the changed code was introduced only very recently, I will fold this
into "ARM: dts: renesas: genmai: Define keyboard switch".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2024-09-30 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27  9:54 [PATCH 0/4] ARM: dts: renesas: use interrupts-extended for gpio-keys Wolfram Sang
2024-09-27  9:54 ` [PATCH 1/4] ARM: dts: renesas: marzen: " Wolfram Sang
2024-09-27 12:29   ` Krzysztof Kozlowski
2024-09-30 14:27   ` Geert Uytterhoeven
2024-09-27  9:54 ` [PATCH 2/4] ARM: dts: renesas: genmai: " Wolfram Sang
2024-09-27 12:29   ` Krzysztof Kozlowski
2024-09-30 14:29   ` Geert Uytterhoeven [this message]
2024-09-27  9:54 ` [PATCH 3/4] ARM: dts: renesas: rskrza1: " Wolfram Sang
2024-09-27 12:30   ` Krzysztof Kozlowski
2024-09-30 14:38     ` Wolfram Sang
2024-09-30 14:29   ` Geert Uytterhoeven
2024-09-27  9:54 ` [PATCH 4/4] ARM: dts: renesas: rza2mevb: " Wolfram Sang
2024-09-30 14:30   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUMGm2nbwC-8Z3yw365PPeDf1eB5Lc6zLVoZ7GauT_R_A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).