From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D0EC433FE for ; Mon, 11 Apr 2022 13:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346213AbiDKNiE (ORCPT ); Mon, 11 Apr 2022 09:38:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiDKNiD (ORCPT ); Mon, 11 Apr 2022 09:38:03 -0400 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ACFD19C32; Mon, 11 Apr 2022 06:35:49 -0700 (PDT) Received: by mail-qk1-f171.google.com with SMTP id b33so10595010qkp.13; Mon, 11 Apr 2022 06:35:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6S8S+a0YX9xrAM7ZLPpu+Eb5jo+Pr1Yp9P1ijuzXncc=; b=rq0LA6dl809CA45g6UnZEmOMAgXLjFJ38JBd8iE1m13fF7LZorRYJUu0Ah8y/1ntoD jkVtiCqLu32wIl4/C2fr6+IOSIHoFiWLDPeW/C+0RMaQulgK5pYLyAKOYyBH64ZfqTGj NbNFDOjRCUUMutAItvZ5PtOWHt4Di5tIGpM7NziEraigAqSnMVYQKucUcX4cas2MTMk0 bURbEHDZVAQkiS30Y3G1cRLGFIyy5/ej/CDe8iWuUchZvMTcCceRMx//vn2sf+Dy8gB/ kqoWNUoRf/7v1vh+xyuMTINiqAiuDyXYbzOMbcC1cT2lcfeCkyrjEFptLUY5fbhecLjo 13iw== X-Gm-Message-State: AOAM532/O2mvglTFcoPtISYwoIQDbfILACWJE1cOrarDrF/nJbGw6sEz VnE6yRvyvQpP45o5AlScH6MVTwF4f03VAA== X-Google-Smtp-Source: ABdhPJzMWbiPHJzD5E/tJf58XoC7dnkFOUfvfYVfnqs00RzsVK0ywczkbe+JqVy07bLaQ5IMZ7599A== X-Received: by 2002:a05:620a:424e:b0:67e:4c1b:baef with SMTP id w14-20020a05620a424e00b0067e4c1bbaefmr22077478qko.778.1649684147723; Mon, 11 Apr 2022 06:35:47 -0700 (PDT) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id s12-20020a05622a018c00b002e1cd88645dsm25399711qtw.74.2022.04.11.06.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 06:35:47 -0700 (PDT) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2ec05db3dfbso44230457b3.7; Mon, 11 Apr 2022 06:35:47 -0700 (PDT) X-Received: by 2002:a0d:e743:0:b0:2eb:3106:9b32 with SMTP id q64-20020a0de743000000b002eb31069b32mr26595858ywe.512.1649684146995; Mon, 11 Apr 2022 06:35:46 -0700 (PDT) MIME-Version: 1.0 References: <20220406172956.3953-1-wens@kernel.org> <20220406172956.3953-3-wens@kernel.org> In-Reply-To: <20220406172956.3953-3-wens@kernel.org> From: Geert Uytterhoeven Date: Mon, 11 Apr 2022 15:35:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106 To: Chen-Yu Tsai Cc: Javier Martinez Canillas , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , David Airlie , Daniel Vetter , Chen-Yu Tsai , DRI Development , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Chen-Yu, On Wed, Apr 6, 2022 at 10:13 PM Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > compatible with the SSD1306. It supports a slightly wider display, > at 132 instead of 128 pixels. The basic commands are the same, but > the SH1106 doesn't support the horizontal or vertical address modes. > > Add a compatible string for it. > > Signed-off-by: Chen-Yu Tsai Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > @@ -13,6 +13,7 @@ maintainers: > properties: > compatible: > enum: > + - sinowealth,sh1106-i2c Please don't introduce new compatible values including the bus type. There is no need for that, and this will only lead to more deprecated compatible values soon... Oops, this is already commit 97a40c23cda5d64a ("dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106") in drm-misc/for-linux-next... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds