Re: [PATCH] clk: renesas: r8a7795: Move MODEMR to DT

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Dirk,

On Thu, Apr 28, 2016 at 8:58 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> On 28.04.2016 08:52, Geert Uytterhoeven wrote:
>> On Thu, Apr 28, 2016 at 8:08 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
>>> @@ -46,7 +48,8 @@ Examples
>>>
>>>          cpg: clock-controller@e6150000 {
>>>                  compatible = "renesas,r8a7795-cpg-mssr";
>>> -               reg = <0 0xe6150000 0 0x1000>;
>>> +               reg = <0 0xe6150000 0 0x1000>,
>>> +                     <0 0xe6160060 0 0x4>;
>>
>>
>> The MODEMR register is not part of the CPG block, but of the RST block.
>> So IMHO it doesn't belong in the clock-controller node.
>
> Ok, fine.
>
> So we agree hat this ugly hard coded register address stuff has to be
> removed and replaced by a device tree based solution. Correct?

Yes we agree.

>> BTW, I still prefer something like
>> "[PATCH 0/6] arm64: renesas: Obtain MD pin values using syscon/regmap"
>> (http://www.spinics.net/lists/linux-sh/msg44757.html).
>
> What's the status of this? I see there a date "1 Sep 2015" ;)

We were considering alternative solutions, cfr. "[PATCH/RFC 0/6] boot-mode-reg:
Add core" (http://www.spinics.net/lists/linux-sh/msg45969.html).
To avoid delaying upstream r8a7795, we settled for the ugly hard coded
register access as an interim solution.

> Is this available in any testing tree we could try?

It used to be part of older renesas-drivers releases.
The patches may still apply, though.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds