[PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support

[PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support

[Wolfram Sang]

These three patches update the bindings and the CMT driver for Renesas
R-Car Gen4 and the r8a779f0 SoC.

Wolfram Sang (3):
  dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT
    support
  dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  clocksource/drivers/sh_cmt: Add R-Car Gen4 support

 .../devicetree/bindings/timer/renesas,cmt.yaml     | 14 ++++++++++++--
 drivers/clocksource/sh_cmt.c                       |  8 ++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.35.1

[PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Wolfram Sang]

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 53dd6d9f518f..7cc1ec4b4e38 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -83,6 +83,11 @@ properties:
               - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
           - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
 
+      - items:
+          - enum:
+              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
+
       - items:
           - enum:
               - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
@@ -100,6 +105,11 @@ properties:
               - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
+      - items:
+          - enum:
+              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
+
   reg:
     maxItems: 1
 
-- 
2.35.1

Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Daniel Lezcano]

On 13/07/2022 12:06, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Krzysztof ?

> ---
>   .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> index 53dd6d9f518f..7cc1ec4b4e38 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> @@ -83,6 +83,11 @@ properties:
>                 - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
>             - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
>   
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> +
>         - items:
>             - enum:
>                 - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> @@ -100,6 +105,11 @@ properties:
>                 - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
>             - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
>   
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> +
>     reg:
>       maxItems: 1
>   


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Krzysztof Kozlowski]

On 16/07/2022 00:35, Daniel Lezcano wrote:
> On 13/07/2022 12:06, Wolfram Sang wrote:
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Krzysztof ?

You got now Rob's. :)


Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Rob Herring]

On Wed, 13 Jul 2022 12:06:01 +0200, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Geert Uytterhoeven]

Hi Wolfram,

On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> @@ -83,6 +83,11 @@ properties:
>                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
>            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
>
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> +
>        - items:
>            - enum:
>                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> @@ -100,6 +105,11 @@ properties:
>                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
>            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
>
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> +
>    reg:
>      maxItems: 1

The above is correct, but you forgot to update the conditional sections
specifying the number of interrupts.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Geert Uytterhoeven]

Hi Wolfram,

On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > @@ -83,6 +83,11 @@ properties:
> >                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> > +
> >        - items:
> >            - enum:
> >                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> > @@ -100,6 +105,11 @@ properties:
> >                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> > +
> >    reg:
> >      maxItems: 1
>
> The above is correct, but you forgot to update the conditional sections
> specifying the number of interrupts.

However, it would have been nice to adhere to the existing sort order
in the file... I will prepare a patch for both issues...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4

[Wolfram Sang]

Despite the name, R-Car V3U is the first member of the R-Car Gen4
family. Hence move its compatible value to the R-Car Gen4 section.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 7cc1ec4b4e38..433ddb49620c 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -80,11 +80,11 @@ properties:
               - renesas,r8a77980-cmt0     # 32-bit CMT0 on R-Car V3H
               - renesas,r8a77990-cmt0     # 32-bit CMT0 on R-Car E3
               - renesas,r8a77995-cmt0     # 32-bit CMT0 on R-Car D3
-              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
           - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
               - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
           - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
 
@@ -102,11 +102,11 @@ properties:
               - renesas,r8a77980-cmt1     # 48-bit CMT on R-Car V3H
               - renesas,r8a77990-cmt1     # 48-bit CMT on R-Car E3
               - renesas,r8a77995-cmt1     # 48-bit CMT on R-Car D3
-              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
               - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
           - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
 
-- 
2.35.1

Re: [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4

[Rob Herring]

On Wed, 13 Jul 2022 12:06:02 +0200, Wolfram Sang wrote:
> Despite the name, R-Car V3U is the first member of the R-Car Gen4
> family. Hence move its compatible value to the R-Car Gen4 section.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4

[Geert Uytterhoeven]

On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Despite the name, R-Car V3U is the first member of the R-Car Gen4
> family. Hence move its compatible value to the R-Car Gen4 section.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds