Re: [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Marek,

What is your stance on this?
Thanks!

On Thu, Jul 4, 2024 at 5:26 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> When creating a dedicated mdio node to describe the bus the gpio reset
> property was erroneously left in the phy node. The reason for adding
> mdio nodes on WhiteHawk was to ensure the PHYs where reset before they
> were probed, keeping the property in the phy node prevented this.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 54bf0c27380b ("arm64: dts: renesas: r8a779g0: Use MDIO node for all AVB devices")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi b/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
> index 80496fb3d476..4f0230327868 100644
> --- a/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/white-hawk-cpu-common.dtsi
> @@ -156,6 +156,8 @@ mdio {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>
> +               reset-gpios = <&gpio7 10 GPIO_ACTIVE_LOW>;
> +
>                 avb0_phy: ethernet-phy@0 {
>                         compatible = "ethernet-phy-id0022.1622",
>                                      "ethernet-phy-ieee802.3-c22";
> @@ -163,7 +165,6 @@ avb0_phy: ethernet-phy@0 {
>                         reg = <0>;
>                         interrupt-parent = <&gpio7>;
>                         interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> -                       reset-gpios = <&gpio7 10 GPIO_ACTIVE_LOW>;
>                 };
>         };
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds