From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sean Anderson <seanga2@gmail.com>
Subject: Re: [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings
Date: Thu, 26 Nov 2020 11:42:46 +0100 [thread overview]
Message-ID: <CAMuHMdU_3B4jogmeisykbeH8QCbUrKMM3Zd8qHftdGGKYbtJoQ@mail.gmail.com> (raw)
In-Reply-To: <CH2PR04MB6522F476C51D4C65F116BE9EE7FB0@CH2PR04MB6522.namprd04.prod.outlook.com>
Hi Damien,
On Tue, Nov 24, 2020 at 11:05 AM Damien Le Moal <Damien.LeMoal@wdc.com> wrote:
> On 2020/11/24 18:49, Geert Uytterhoeven wrote:
> > On Tue, Nov 24, 2020 at 5:40 AM Damien Le Moal <damien.lemoal@wdc.com> wrote:
> >> Document the device tree bindings for the Canaan Kendryte K210 SoC
> >> Fully Programmable IO Array (FPIOA) pinctrl driver in
> >> Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml. The
> >> new header file include/dt-bindings/pinctrl/k210-fpioa.h is added to
> >> define all 256 possible pin functions of the SoC IO pins, as well as
> >> macros simplifying the definition of pin functions in a device tree.
> >>
> >> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> >
> > Thanks for your patch!
> >
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml
> >
> >> + canaan,k210-sysctl-power:
> >> + $ref: /schemas/types.yaml#/definitions/phandle-array
> >> + description: |
> >> + phandle of the K210 system controller node and offset of the its
> >
> > of its
> >
> >> + power domain control register.
> >
> > Your k210-sysctl-v15 branch has a bogus trailing space here.
>
> Oops. Forgot to push the fixed up patches. Just did it now (forced update
> k210-sysctl-v15).
$ make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml
Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml:59:1:
[error] syntax error: found character '\t' that cannot start any token
(syntax)
DT binding files should use spaces, not TABs.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-11-26 10:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 4:37 [PATCH v2 00/21] RISC-V Kendryte K210 support improvements Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 01/21] riscv: Fix kernel time_init() Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 02/21] riscv: Fix sifive serial driver Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 03/21] riscv: Enable interrupts during syscalls with M-Mode Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 04/21] riscv: Fix builtin DTB handling Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 05/21] riscv: Use vendor name for K210 SoC support Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 06/21] dt-bindings: Add Canaan vendor prefix Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 07/21] dt-binding: Document canaan,k210-clk bindings Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 08/21] dt-bindings: Document canaan,k210-rst bindings Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings Damien Le Moal
2020-11-24 9:48 ` Geert Uytterhoeven
2020-11-24 10:05 ` Damien Le Moal
2020-11-26 10:42 ` Geert Uytterhoeven [this message]
2020-11-26 10:52 ` Damien Le Moal
2020-11-30 16:39 ` Rob Herring
2020-11-24 4:37 ` [PATCH v2 10/21] dt-binding: Document canaan,k210-sysctl bindings Damien Le Moal
2020-11-30 16:40 ` Rob Herring
2020-11-24 4:37 ` [PATCH v2 11/21] riscv: Add Canaan Kendryte K210 clock driver Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 12/21] riscv: Add Canaan Kendryte K210 FPIOA driver Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 13/21] riscv: Add Canaan Kendryte K210 reset controller Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 14/21] riscv: Update Kendryte K210 device tree Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 15/21] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 16/21] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 17/21] riscv: Add SiPeed MAIX GO " Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 18/21] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 19/21] riscv: Add Kendryte KD233 " Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 20/21] riscv: Update Canaan Kendryte K210 defconfig Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 21/21] riscv: Add Canaan Kendryte K210 SD card defconfig Damien Le Moal
2020-11-24 18:51 ` Geert Uytterhoeven
2020-11-25 0:05 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU_3B4jogmeisykbeH8QCbUrKMM3Zd8qHftdGGKYbtJoQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Damien.LeMoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).