From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v4 2/5] [RFC] clk: shmobile: Add r8a7795 CPG Core Clock Definitions Date: Fri, 23 Oct 2015 13:25:14 +0200 Message-ID: References: <1444999760-15750-1-git-send-email-geert+renesas@glider.be> <1444999760-15750-3-git-send-email-geert+renesas@glider.be> <2464036.AexIB1O0H1@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <2464036.AexIB1O0H1@avalon> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Magnus Damm , Simon Horman , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-clk , "devicetree@vger.kernel.org" , Linux-sh list List-Id: devicetree@vger.kernel.org Hi Laurent, On Fri, Oct 23, 2015 at 1:21 PM, Laurent Pinchart wrote: >> +#define R8A7795_CLK_R 45 >> +#define R8A7795_CLK_OSC 46 > > Those two clocks are called RCLK and OSCCLK in the datasheet, shouldn= 't we use > those names ? =2E.._CLK_RCLK and ..._CLK_OSCCLK sound a bit heavy to me. Besides, all other clocks in the datasheet have a "=CF=86" suffix, whic= h also means "CLK", and which we don't retain. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. -- Linus Torvalds