Re: [RFC PATCH v2 07/21] dt-bindings: mmc: renesas,sdhi: add optional SDnH clock

Re: [RFC PATCH v2 07/21] dt-bindings: mmc: renesas,sdhi: add optional SDnH clock

[Geert Uytterhoeven]

Hi Wolfram,

CC devicetree

On Wed, Nov 10, 2021 at 8:16 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Changes since RFC v1:
> * use 'oneOf' for the clock-names

Thanks for the update!

> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -132,12 +132,20 @@ allOf:
>        properties:
>          clocks:
>            minItems: 1
> -          maxItems: 2
> +          maxItems: 3
>          clock-names:
> -          minItems: 1
> -          items:
> +          oneOf:
>              - const: core
> -            - const: cd
> +            - items:
> +                - const: core
> +                - const: cd
> +            - items:
> +                - const: core
> +                - const: clkh
> +            - items:
> +                - const: core
> +                - const: clkh
> +                - const: cd

That can be simplified to:

        clock-names:
          minItems: 1
          maxItems: 3
          uniqueItems: true
          items:
            - const: core
            - enum: [ clkh, cd ]
            - const: cd

But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC PATCH v2 07/21] dt-bindings: mmc: renesas,sdhi: add optional SDnH clock

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi Geert,

> That can be simplified to:
> 
>         clock-names:
>           minItems: 1
>           maxItems: 3
>           uniqueItems: true
>           items:
>             - const: core
>             - enum: [ clkh, cd ]
>             - const: cd

OK, nice.

> But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"?

I don't think so because I assume all following generations will have
clkh as well.

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [RFC PATCH v2 07/21] dt-bindings: mmc: renesas,sdhi: add optional SDnH clock

[Geert Uytterhoeven]

Hi Wolfram,

On Fri, Nov 12, 2021 at 12:57 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > That can be simplified to:
> >
> >         clock-names:
> >           minItems: 1
> >           maxItems: 3
> >           uniqueItems: true
> >           items:
> >             - const: core
> >             - enum: [ clkh, cd ]
> >             - const: cd
>
> OK, nice.
>
> > But shouldn't the clkh case be restricted to "renesas,rcar-gen3-sdhi"?
>
> I don't think so because I assume all following generations will have
> clkh as well.

My issue is that the _previous_ generations (e.g. SH/R-Mobile and
RZ/A[12]) do not have it.

R-Car Gen2 has SDH clocks and the clock driver implements them,
but they are always disabled, as there are no users.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds