devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 2/7] ARM: dts: r8a7744: Initial SoC device tree
Date: Fri, 30 Nov 2018 09:53:12 +0100	[thread overview]
Message-ID: <CAMuHMdUzPDW=3569eN1XLSC90=TXiRE272KgBdv8cf7iw=XRbw@mail.gmail.com> (raw)
In-Reply-To: <1542878075-61314-3-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

On Thu, Nov 22, 2018 at 10:23 AM Biju Das <biju.das@bp.renesas.com> wrote:
> Basic support for the RZ/G1N (R8A7744) SoC. Added placeholders
> to avoid compilation error with the common platform code.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a7744.dtsi
> @@ -0,0 +1,369 @@

> +       soc {

> +               gic: interrupt-controller@f1001000 {
> +                       compatible = "arm,gic-400";
> +                       #interrupt-cells = <3>;
> +                       #address-cells = <0>;
> +                       interrupt-controller;
> +                       reg = <0 0xf1001000 0 0x1000>, <0 0xf1002000 0 0x2000>,
> +                             <0 0xf1004000 0 0x2000>, <0 0xf1006000 0 0x2000>;
> +                       interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;

Tehcnically, this mask should be GIC_CPU_MASK_SIMPLE(1)
until you add the second CPU node.

> +       timer {
> +               compatible = "arm,armv7-timer";
> +               interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> +                                     <&gic GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> +                                     <&gic GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
> +                                     <&gic GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;

Likewise.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2018-11-30  8:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  9:14 [PATCH 0/7] Add support for iWave G20D-Q7 board based on RZ/G1N Biju Das
2018-11-22  9:14 ` [PATCH 1/7] ARM: dts: r8a7744-iwg20m: Add iWave RZ/G1N Qseven SOM Biju Das
2018-11-29 12:50   ` Simon Horman
2018-11-30  9:44   ` Geert Uytterhoeven
2018-11-30 10:04     ` Biju Das
2018-11-22  9:14 ` [PATCH 2/7] ARM: dts: r8a7744: Initial SoC device tree Biju Das
2018-11-29 12:50   ` Simon Horman
2018-11-30  8:48   ` Geert Uytterhoeven
2018-11-30  9:15     ` Biju Das
2018-11-30  8:53   ` Geert Uytterhoeven [this message]
2018-11-22  9:14 ` [PATCH 3/7] ARM: dts: r8a7744-iwg20d-q7: Add support for iWave G20D-Q7 board based on RZ/G1N Biju Das
2018-11-29 12:50   ` Simon Horman
2018-11-30  9:46   ` Geert Uytterhoeven
2018-11-22  9:14 ` [PATCH 4/7] ARM: dts: r8a7744: Add SYS-DMAC support Biju Das
2018-11-29 12:50   ` Simon Horman
2018-11-30  8:49   ` Geert Uytterhoeven
2018-11-22  9:14 ` [PATCH 5/7] ARM: dts: r8a7744: Add GPIO support Biju Das
2018-11-29 12:51   ` Simon Horman
2018-11-30  8:49   ` Geert Uytterhoeven
2018-11-22  9:14 ` [PATCH 6/7] ARM: dts: r8a7744: Add Ethernet AVB support Biju Das
2018-11-29 12:51   ` Simon Horman
2018-11-30  8:50   ` Geert Uytterhoeven
2018-11-22  9:14 ` [PATCH 7/7] ARM: dts: r8a7744: Add SMP support Biju Das
2018-11-29 12:49   ` Simon Horman
2018-11-29 13:31     ` Biju Das
2018-11-30  8:54   ` Geert Uytterhoeven
2018-11-30  9:22     ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUzPDW=3569eN1XLSC90=TXiRE272KgBdv8cf7iw=XRbw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).