Re: [PATCH v2 09/15] auxdisplay: linedisp: Add support for overriding character mapping

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Andy,

On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There is already the driver using character mapping table for
> 7 or 14 segment display. It is possible to override it. Make
> the similar in the line display library to allow other drivers
> to utilise the same functionality.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

One question below.

> --- a/drivers/auxdisplay/line-display.c
> +++ b/drivers/auxdisplay/line-display.c

> +static const struct attribute_group linedisp_group = {
> +       .is_visible     = linedisp_attr_is_visible,

Shouldn't that be .is_bin_visible?

> +       .attrs          = linedisp_attrs,

Likewise, .bin_attrs?
But that is a pre-existing issue in the ht16k33 driver.

> +};
> +__ATTRIBUTE_GROUPS(linedisp);

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds