From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8AACA9EBC for ; Fri, 25 Oct 2019 07:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7198A21D82 for ; Fri, 25 Oct 2019 07:47:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391001AbfJYHrQ (ORCPT ); Fri, 25 Oct 2019 03:47:16 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:42681 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbfJYHrQ (ORCPT ); Fri, 25 Oct 2019 03:47:16 -0400 Received: by mail-oi1-f194.google.com with SMTP id i185so921163oif.9; Fri, 25 Oct 2019 00:47:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8zZtV2+T6wNs6wwQzlNZ1qpgoJVUirP0Vg0dJEJ2LHU=; b=MHxrOpqGq4xo2+2n54Zv07nd8+wD33s5MSB9p5hig9053aIh1VzVnKhdPl2RPyoIhg TCa10jY5nfKHiR7lp2VP41IV8Pvt0c1JEvDgeabkWGXmW7C+qVHu7OPCmJZ3TLIP+AHP ivTrc8TwGR6H9cR2O+073confFc37sI++1kGu6GivUIWIfCItq4EsHXJnb6yVJ2pSKrx kf3xfdBmwgWx4stDFIdDVm8VPm2FM+M5VOTN7PSsOt3WEmBfhdS9baC0kHImt4zG1aa5 V7n52Vy8boCURcHqStzQ+Wm8VqzwaqgT1eCiPCkALyJfFAW3RB0TzZFaE/RN0ulzx7ZI Bdxg== X-Gm-Message-State: APjAAAXlmPwRly66QOWc8F+AvJlvz0pMzUBfSp0/z52GRzhiSsUebnlC BdZoDb4Xduvzw8yKLt4LiUROOn5E61AJllBfADw= X-Google-Smtp-Source: APXvYqz2j1UKxPbK8D0J/lYB0lvG5GuWdZkQfM2ar/MyijONb1BrRq7aN1+gUIH15B2ywbc4PnGj5rJ7bKq9QfnqEE0= X-Received: by 2002:aca:882:: with SMTP id 124mr1813914oii.54.1571989635617; Fri, 25 Oct 2019 00:47:15 -0700 (PDT) MIME-Version: 1.0 References: <1571915821-1620-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1571915821-1620-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 25 Oct 2019 09:47:04 +0200 Message-ID: Subject: Re: [PATCH 2/3] clk: renesas: rcar-usb2-clock-sel: Add multiple clocks management To: Yoshihiro Shimoda Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Geert Uytterhoeven , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Shimoda-san, On Fri, Oct 25, 2019 at 3:36 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Thursday, October 24, 2019 8:35 PM > > > > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c > > > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c > > > @@ -131,6 +156,14 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev) > > > pm_runtime_enable(dev); > > > pm_runtime_get_sync(dev); > > > > pm_runtime_get_sync() will have already enabled the first module clock listed in > > the DT "clocks" property. > > > > If you want the driver to manage all clocks itself, perhaps the PM Runtime > > calls should be dropped? > > I'm thinking PM Runtime calls are related to power domain control so that we cannot > drop it. Or, since the hardware is the Always-on domain, can we drop it anyway? That's right: if the hardware block ever ends up in a non-always-on power domain, you won't have a choice but to use PM Runtime. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds