From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v6 2/6] dt-bindings: Add the rzn1-clocks.h file Date: Wed, 30 May 2018 15:36:44 +0200 Message-ID: References: <1526983321-41949-1-git-send-email-michel.pollet@bp.renesas.com> <1526983321-41949-3-git-send-email-michel.pollet@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Phil Edworthy Cc: M P , Michel Pollet , Linux-Renesas , Simon Horman , Michel Pollet , Magnus Damm , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Geert Uytterhoeven , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , linux-clk List-Id: devicetree@vger.kernel.org Hi Phil, On Wed, May 30, 2018 at 3:30 PM, Phil Edworthy wrote: > On 25 May 2018 10:13 Geert Uytterhoeven wrote: > [snip] > >> Now, given the clock definitions for RZ/N1[DSL] are the same (although some >> don't exist on some variants), you could keep on using RZN1_CLK_FOO for >> the names of the defines, and store them in a common file, included by the >> soc-specific file. But please make clear the common file cannot be included >> directly, so the filename does not become part of the DT ABI, and you are >> shielded from future marketing silliness (e.g. next quarter's RZ/N1X being >> totally different). > How does an include filename become part of the DT ABI? > I thought the dtb is the ABI, not the dts. Am I wrong? You're right. In se the DT ABI applies to the DTB, not to the DTS. The definitions inside the include file are part of the DT bindings, and thus cannot be changed. Your DTS files get these definitions by including the header file, so the header filename is also part of the bindings, and thus can't be changed that easily. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds