From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F282DC4338F for ; Mon, 23 Aug 2021 09:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D73F561002 for ; Mon, 23 Aug 2021 09:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231444AbhHWJXb (ORCPT ); Mon, 23 Aug 2021 05:23:31 -0400 Received: from mail-vs1-f44.google.com ([209.85.217.44]:47095 "EHLO mail-vs1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhHWJXb (ORCPT ); Mon, 23 Aug 2021 05:23:31 -0400 Received: by mail-vs1-f44.google.com with SMTP id f13so10610108vsl.13; Mon, 23 Aug 2021 02:22:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gt+eojLYgADvAa13MxSZYGtUVyb5L5ebuzo5ONxZgrI=; b=BnmQ1yr/AnjAJB0x3XpXN9UZ36Onkk+a6DJE3xEBI2elkbOqtGiiI3OAmdGmQAozD1 KUbyJIK3HmQGFmFVVcH4ok0FBRIlTM/Oume5ShU1ObcpfprAR+iiSD3aX5awwGPDnc+L D8PN4zJXEi5SMa7nyBlz6IRfNJiR51P5YekqfdzcYJN5gXU8i+jJk9+PxWtXrZDLCANq fEVrLn5qTnl01WWERhBA0wj5dLzAQLaG8Lg1U1dHK1kgQ0C3RJjojBhfehqH5TrD00ss qmpQDmVabFlnsFIz2xQ5U+YiIAeTFTgbhAvD02y8OQiCIcTQZctk1ALdN0/DRHQy0+dA 9ARQ== X-Gm-Message-State: AOAM530hqRcr2TA1h9T/nl30QRqmidb/7Jm9tHg7YB4TA0QLK8Q1nQAk oqP0inDWFWqHJwwHqg8BP2TXN307TDovR9E4Ns4= X-Google-Smtp-Source: ABdhPJz28fxMG9kfJf8GETxTvqUtwihBTWhZXmcu12UH1nD6e1mE1lJ+gKdP0AYCAbP1FuvP0Zlts11yKSODJ4rQIdU= X-Received: by 2002:a67:cb0a:: with SMTP id b10mr22882432vsl.9.1629710568318; Mon, 23 Aug 2021 02:22:48 -0700 (PDT) MIME-Version: 1.0 References: <20210812151808.7916-1-biju.das.jz@bp.renesas.com> <20210812151808.7916-4-biju.das.jz@bp.renesas.com> <2f5f8999-260d-e9c0-731e-df644b528b61@gmail.com> <05bdd9e8-e68f-c8b4-a7d9-a83f2ca97a58@omp.ru> In-Reply-To: <05bdd9e8-e68f-c8b4-a7d9-a83f2ca97a58@omp.ru> From: Geert Uytterhoeven Date: Mon, 23 Aug 2021 11:22:36 +0200 Message-ID: Subject: Re: [PATCH v6 3/3] arm64: dts: renesas: r9a07g044: Add USB2.0 device support To: Sergey Shtylyov Cc: Biju Das , Rob Herring , Magnus Damm , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sergey, On Tue, Aug 17, 2021 at 6:41 PM Sergey Shtylyov wrote: > On 8/17/21 2:12 PM, Biju Das wrote: > [...] > >>>> Add USB2.0 device support to RZ/G2L SoC DT. > >>>> > >>>> Signed-off-by: Biju Das > >>>> Reviewed-by: Lad Prabhakar > >>>> Reviewed-by: Geert Uytterhoeven > >>> [...] > >>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > >>> b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > >>>> index de78c921af22..2f313c2a81c7 100644 > >>>> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > >>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi > >>>> @@ -391,6 +391,25 @@ > >>>> power-domains = <&cpg>; > >>>> status = "disabled"; > >>>> }; > >>>> + > >>>> + hsusb: usb@11c60000 { > >>>> + compatible = "renesas,usbhs-r9a07g044", > >>>> + "renesas,rza2-usbhs"; > >>>> + reg = <0 0x11c60000 0 0x10000>; > >>>> + interrupts = , > >>>> + , > >>>> + , > >>>> + ; > >>> > >>> Don't we need to specify "interrupt-names" when there a more than 1 > >>> interrupts? > >> > >> This dtsi changes, as per binding documentation [1]. As you see, > >> "interrupt-names" is optional. > > > > For now I will go with current dt changes. > > > > Later I will create incremental patches for dt-binding with optional "interrupt-names", > > "clock-names" and "reset names" for all the SoC's supported by this binding doc. > > > > After that, will send an incremental patch with adding optional properties in all SoC dtsi. > > > > Does it make sense? > > I had the impression that the "*-names" prop was mandatory for a "*" prop having 2 values or mores. > If it's now allowed to be optional, don't bother with that at all. There's a difference between "mandatory according to good DT binding design" and "mandatory according to the actual json-schema DT bindings". For now the tools only enforce the latter... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds