From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 10/13] arm64: dts: renesas: rzg2ul-smarc: Enable USB2.0 support
Date: Thu, 28 Apr 2022 16:04:13 +0200 [thread overview]
Message-ID: <CAMuHMdVBczjWQQdeaiE4NvgvZUc+tkK0o8unoD5ngjGaOM1JCg@mail.gmail.com> (raw)
In-Reply-To: <20220425170530.200921-11-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, Apr 25, 2022 at 7:06 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Enable USB2.0 Host/Device support on RZ/G2L SMARC EVK by
> deleting the nodes which disabled it.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts
> @@ -20,54 +20,8 @@ &canfd {
> status = "disabled";
> };
>
> -&ehci0 {
> - /delete-property/ pinctrl-0;
> - /delete-property/ pinctrl-names;
> - status = "disabled";
> -};
> -
> -&ehci1 {
> - /delete-property/ pinctrl-0;
> - /delete-property/ pinctrl-names;
> - status = "disabled";
> -};
> -
> -&hsusb {
> - /delete-property/ pinctrl-0;
> - /delete-property/ pinctrl-names;
> - status = "disabled";
> -};
> -
> -&ohci0 {
> - /delete-property/ pinctrl-0;
> - /delete-property/ pinctrl-names;
> - status = "disabled";
> -};
> -
> -&ohci1 {
> - /delete-property/ pinctrl-0;
> - /delete-property/ pinctrl-names;
> - status = "disabled";
> -};
Looks like lots of non-existent pinctrl properties were deleted.
Anyway, they'll be gone soon ;-)
> --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> @@ -77,4 +77,15 @@ ssi1_pins: ssi1 {
> <RZG2L_PORT_PINMUX(3, 2, 2)>, /* TXD */
> <RZG2L_PORT_PINMUX(3, 3, 2)>; /* RXD */
> };
> +
> + usb0_pins: usb0 {
> + pinmux = <RZG2L_PORT_PINMUX(5, 0, 1)>, /* VBUS */
> + <RZG2L_PORT_PINMUX(5, 2, 1)>, /* OVC */
> + <RZG2L_PORT_PINMUX(5, 3, 1)>; /* OTG_ID */
> + };
> +
> + usb1_pins: usb1 {
> + pinmux = <RZG2L_PORT_PINMUX(5, 4, 5)>, /* VBUS */
/* OVC */?
> + <RZG2L_PORT_PINMUX(6, 0, 1)>; /* OVC */
/*VBUS */?
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-04-28 14:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 17:05 [PATCH 00/13] Add CAN, Audio, USB, WDT and Timer support Biju Das
2022-04-25 17:05 ` [PATCH 01/13] arm64: dts: renesas: r9a07g043: Add I2C2 node and fillup the I2C{0,1,3} stub nodes Biju Das
2022-04-28 12:58 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 02/13] arm64: dts: renesas: r9a07g043: Add SSI{1,2,3} nodes and fillup the SSI0 stub node Biju Das
2022-04-28 12:58 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 03/13] arm64: dts: renesas: r9a07g043: Add USB2.0 support Biju Das
2022-04-28 13:01 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 04/13] arm64: dts: renesas: r9a07g043: Fillup the CANFD stub node Biju Das
2022-04-28 13:02 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 05/13] arm64: dts: renesas: r9a07g043: Fillup the OSTM{0,1,2} stub nodes Biju Das
2022-04-28 13:03 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 06/13] arm64: dts: renesas: r9a07g043: Fillup the WDT{0,2} " Biju Das
2022-04-28 13:03 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 07/13] arm64: dts: renesas: rzg2ul-smarc: Enable i2c{0,1} and wm8978 Biju Das
2022-04-28 13:40 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 08/13] arm64: dts: renesas: rzg2l-smarc: Move ssi0 and cpu sound_dai nodes from common dtsi Biju Das
2022-04-28 13:48 ` Geert Uytterhoeven
2022-04-28 14:11 ` Biju Das
2022-04-25 17:05 ` [PATCH 09/13] arm64: dts: renesas: rzg2ul-smarc: Enable Audio Biju Das
2022-04-28 13:54 ` Geert Uytterhoeven
2022-04-28 14:20 ` Biju Das
2022-04-25 17:05 ` [PATCH 10/13] arm64: dts: renesas: rzg2ul-smarc: Enable USB2.0 support Biju Das
2022-04-28 14:04 ` Geert Uytterhoeven [this message]
2022-04-28 14:35 ` Biju Das
2022-04-25 17:05 ` [PATCH 11/13] arm64: dts: renesas: rzg2ul-smarc: Enable CANFD Biju Das
2022-04-28 14:09 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 12/13] arm64: dts: renesas: rzg2ul-smarc-som: Enable OSTM Biju Das
2022-04-28 14:09 ` Geert Uytterhoeven
2022-04-25 17:05 ` [PATCH 13/13] arm64: dts: renesas: rzg2ul-smarc-som: Enable watchdog Biju Das
2022-04-28 14:10 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVBczjWQQdeaiE4NvgvZUc+tkK0o8unoD5ngjGaOM1JCg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).