From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C702BC433EF for ; Thu, 28 Apr 2022 14:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbiD1OJJ (ORCPT ); Thu, 28 Apr 2022 10:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348169AbiD1OIv (ORCPT ); Thu, 28 Apr 2022 10:08:51 -0400 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D87F6A6E28; Thu, 28 Apr 2022 07:05:18 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id bu29so8901316lfb.0; Thu, 28 Apr 2022 07:05:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bNf9rw2GTPgYpzsW80GmkQGexZVGoKA1BJoGlD8No+Y=; b=VogqCRmhxFkRwr8nDBNgvHaCmpyjlhzoZkhjMjt9m1SOvLlH/nQp63XS0gjtm2DnE6 kIT6xmVk7rhX5iiV0DOzbrrctb9zbFrHCI0QQZnw8M2a4ZpE7zg0Hze9BkDeomGCWB8i KrrQZW85YMsNrLDc+wCJ3OB6z708a15uTkJnFj8ewUZQM307laJEhyGYEbVWngcHQnVF ka28f0LymsZPa7x+i0RFRIMv7J3PLXxVKgXWa0ykMktvhH5EH9bKdwzYVIWzWyIsSj1r kJ6dWaeaoP5hj3NwoK8jPl9VmzVH/GflxjwqIoD6Bbs3A8cOzthM7IUp42YVw9T+D6hd 3Vuw== X-Gm-Message-State: AOAM533LjGgvX6/mmKNuB+WtD7ICj9uSUSfu0LLnqFkhBwVrCWsSrXlz PYaGANP7p+X18MVboi6q9fSWxccy6zANwiNs X-Google-Smtp-Source: ABdhPJwYmpDcH9rfbQctdeLxnv3zG9kxNikjMmwg4q5LWi8UcTSv0oOtaILBn2x9YjDiBqykIWy7QA== X-Received: by 2002:a05:6512:1511:b0:44a:2f74:3c1c with SMTP id bq17-20020a056512151100b0044a2f743c1cmr23760737lfb.114.1651154716976; Thu, 28 Apr 2022 07:05:16 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id f22-20020a2e6a16000000b0024f0cf6fdb0sm3139ljc.138.2022.04.28.07.04.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 07:04:43 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id j4so8811156lfh.8; Thu, 28 Apr 2022 07:04:34 -0700 (PDT) X-Received: by 2002:a05:6512:12c6:b0:44a:650f:3b86 with SMTP id p6-20020a05651212c600b0044a650f3b86mr25233083lfg.79.1651154668136; Thu, 28 Apr 2022 07:04:28 -0700 (PDT) MIME-Version: 1.0 References: <20220425170530.200921-1-biju.das.jz@bp.renesas.com> <20220425170530.200921-11-biju.das.jz@bp.renesas.com> In-Reply-To: <20220425170530.200921-11-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 28 Apr 2022 16:04:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/13] arm64: dts: renesas: rzg2ul-smarc: Enable USB2.0 support To: Biju Das Cc: Rob Herring , Krzysztof Kozlowski , Magnus Damm , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Biju, On Mon, Apr 25, 2022 at 7:06 PM Biju Das wrote: > Enable USB2.0 Host/Device support on RZ/G2L SMARC EVK by > deleting the nodes which disabled it. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts > +++ b/arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts > @@ -20,54 +20,8 @@ &canfd { > status = "disabled"; > }; > > -&ehci0 { > - /delete-property/ pinctrl-0; > - /delete-property/ pinctrl-names; > - status = "disabled"; > -}; > - > -&ehci1 { > - /delete-property/ pinctrl-0; > - /delete-property/ pinctrl-names; > - status = "disabled"; > -}; > - > -&hsusb { > - /delete-property/ pinctrl-0; > - /delete-property/ pinctrl-names; > - status = "disabled"; > -}; > - > -&ohci0 { > - /delete-property/ pinctrl-0; > - /delete-property/ pinctrl-names; > - status = "disabled"; > -}; > - > -&ohci1 { > - /delete-property/ pinctrl-0; > - /delete-property/ pinctrl-names; > - status = "disabled"; > -}; Looks like lots of non-existent pinctrl properties were deleted. Anyway, they'll be gone soon ;-) > --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi > @@ -77,4 +77,15 @@ ssi1_pins: ssi1 { > , /* TXD */ > ; /* RXD */ > }; > + > + usb0_pins: usb0 { > + pinmux = , /* VBUS */ > + , /* OVC */ > + ; /* OTG_ID */ > + }; > + > + usb1_pins: usb1 { > + pinmux = , /* VBUS */ /* OVC */? > + ; /* OVC */ /*VBUS */? > + }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds