* [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
@ 2017-08-14 11:19 Biju Das
2017-08-14 14:22 ` Geert Uytterhoeven
0 siblings, 1 reply; 9+ messages in thread
From: Biju Das @ 2017-08-14 11:19 UTC (permalink / raw)
To: Ulf Hansson, Wolfram Sang, Rob Herring, Mark Rutland
Cc: Simon Horman, Magnus Damm, Chris Paterson, devicetree,
linux-renesas-soc, linux-arm-kernel, linux-mmc, Biju Das
Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
This patch is compiled and tested against mmc/next.
drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 718cb8a..f709f7f 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -95,6 +95,8 @@
{ .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
{ .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
{ .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
+ { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
+ { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-14 11:19 [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support Biju Das
@ 2017-08-14 14:22 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVDqgbwKzxFoxajLLFHZC80NT5vrDLnpb9sFj+DL-1zDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-08-14 14:22 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Wolfram Sang, Rob Herring, Mark Rutland,
Simon Horman, Magnus Damm, Chris Paterson,
devicetree@vger.kernel.org, Linux-Renesas,
linux-arm-kernel@lists.infradead.org, Linux MMC List
On Mon, Aug 14, 2017 at 1:19 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch is compiled and tested against mmc/next.
>
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 718cb8a..f709f7f 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -95,6 +95,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
I guess we want generic R-Car Gen2/3 compatible values here, too?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
@ 2017-08-14 11:39 Biju Das
2017-08-17 20:48 ` Rob Herring
2017-08-21 8:25 ` Wolfram Sang
0 siblings, 2 replies; 9+ messages in thread
From: Biju Das @ 2017-08-14 11:39 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Mark Rutland
Cc: Simon Horman, Magnus Damm, Chris Paterson, Wolfram Sang,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mmc-u79uwXL29TY76Z2rM5mHXA, Biju Das
Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.
Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
This patch is compiled and tested againt linux next tag
next-20170811. This patch depend on the driver change
[PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
https://patchwork.kernel.org/patch/9898611/
Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
index 4fd8b7a..0d507ec 100644
--- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
@@ -15,6 +15,8 @@ Required properties:
"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+ "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+ "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -34,8 +36,8 @@ Required properties:
"core" and "cd". If the controller only has 1 clock, naming is not
required.
Below is the number clocks for each supported SoC:
- 1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
- R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
+ 1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
+ R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
2: R7S72100
Optional properties:
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-14 11:39 Biju Das
@ 2017-08-17 20:48 ` Rob Herring
2017-08-21 8:25 ` Wolfram Sang
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2017-08-17 20:48 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Mark Rutland, Simon Horman, Magnus Damm,
Chris Paterson, Wolfram Sang, devicetree, linux-renesas-soc,
linux-arm-kernel, linux-mmc
On Mon, Aug 14, 2017 at 12:39:26PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch is compiled and tested againt linux next tag
> next-20170811. This patch depend on the driver change
> [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
> https://patchwork.kernel.org/patch/9898611/
>
>
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-14 11:39 Biju Das
2017-08-17 20:48 ` Rob Herring
@ 2017-08-21 8:25 ` Wolfram Sang
2017-08-21 9:47 ` Biju Das
1 sibling, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2017-08-21 8:25 UTC (permalink / raw)
To: Biju Das
Cc: Ulf Hansson, Rob Herring, Mark Rutland, Simon Horman, Magnus Damm,
Chris Paterson, Wolfram Sang, devicetree, linux-renesas-soc,
linux-arm-kernel, linux-mmc
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
> Below is the number clocks for each supported SoC:
> - 1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> - R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> + 1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
> + R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> 2: R7S72100
Hmm, maybe we should convert this to only listing SoCs with two clocks?
That will be easier to maintaine since the majority seems to have one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
2017-08-21 8:25 ` Wolfram Sang
@ 2017-08-21 9:47 ` Biju Das
0 siblings, 0 replies; 9+ messages in thread
From: Biju Das @ 2017-08-21 9:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: Ulf Hansson, Rob Herring, Mark Rutland, Simon Horman, Magnus Damm,
Chris Paterson, Wolfram Sang, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org
> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@the-dreams.de]
> Sent: 21 August 2017 09:25
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>; Rob Herring <robh+dt@kernel.org>;
> Mark Rutland <mark.rutland@arm.com>; Simon Horman
> <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris
> Paterson <Chris.Paterson2@renesas.com>; Wolfram Sang
> <wsa+renesas@sang-engineering.com>; devicetree@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> mmc@vger.kernel.org
> Subject: Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
>
>
> > Below is the number clocks for each supported SoC:
> > - 1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> > - R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> > + 1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778,
> R8A7779,
> > + R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795,
> R8A7796
> > 2: R7S72100
>
> Hmm, maybe we should convert this to only listing SoCs with two clocks?
> That will be easier to maintaine since the majority seems to have one.
Ok. I will send v2 with the suggested changes.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-08-21 9:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-14 11:19 [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support Biju Das
2017-08-14 14:22 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVDqgbwKzxFoxajLLFHZC80NT5vrDLnpb9sFj+DL-1zDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-14 15:15 ` Chris Paterson
[not found] ` <TY1PR06MB070269842CD923E4DE4FE6EDB78C0-/PRLmSCtZ14u2TXDOttQZW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-14 15:20 ` Geert Uytterhoeven
2017-08-14 15:23 ` Chris Paterson
-- strict thread matches above, loose matches on Subject: below --
2017-08-14 11:39 Biju Das
2017-08-17 20:48 ` Rob Herring
2017-08-21 8:25 ` Wolfram Sang
2017-08-21 9:47 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).