From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 6/6] [RFC] arm: shmobile: genmai reference: Add RSPI nodes Date: Fri, 27 Dec 2013 20:08:18 +0100 Message-ID: References: <1387886210-3634-1-git-send-email-geert+renesas@linux-m68k.org> <1387886210-3634-7-git-send-email-geert+renesas@linux-m68k.org> <2198668.ESbmzZvna4@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <2198668.ESbmzZvna4@avalon> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: Geert Uytterhoeven , Linux-sh list , "linux-arm-kernel@lists.infradead.org" , linux-spi@vger.kernel.org, "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Fri, Dec 27, 2013 at 5:20 PM, Laurent Pinchart wrote: > On Tuesday 24 December 2013 12:56:50 Geert Uytterhoeven wrote: >> Add pinctrl and SPI devices for RSPI on Genmai. >> >> On this board, only rspi4 is in use. It's bus contains a single device >> (a wm8978 audio codec), for which no bindings are defined yet. >> >> Signed-off-by: Geert Uytterhoeven >> Cc: devicetree@vger.kernel.org >> --- >> arch/arm/boot/dts/r7s72100-genmai-reference.dts | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/r7s72100-genmai-reference.dts >> b/arch/arm/boot/dts/r7s72100-genmai-reference.dts index >> 114510f8bf09..6d99630627e4 100644 >> --- a/arch/arm/boot/dts/r7s72100-genmai-reference.dts >> +++ b/arch/arm/boot/dts/r7s72100-genmai-reference.dts >> @@ -43,7 +43,7 @@ >> }; >> >> &pfc { >> - pinctrl-0 = <&scif2_pins ðernet_pins>; >> + pinctrl-0 = <&scif2_pins ðernet_pins &rspi4_pins>; > > You should add pinctrl-0 and pinctrl-names properties to the spi4 node > instead. Device nodes should reference their pinctrl configuration directly, > scif2 and ethernet are exceptions as DT bindings for those devices are not in > mainline yet. I put it there because the actual driver doesn't use DT yet. Is that OK? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds