devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054
@ 2022-02-06 18:47 Biju Das
  2022-02-06 18:47 ` [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC Biju Das
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Biju Das @ 2022-02-06 18:47 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Biju Das, Geert Uytterhoeven, linux-serial, devicetree,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
	linux-renesas-soc

This patch removes redundant "renesas,scif-r9a07g054" from binding
documentation as it uses renesas,scif-r9a07g044 fallback.

Whilst remove the additional renesas,scif-r9a07g054 from Items.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/serial/renesas,scif.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index ba5d3e0acc63..461392091579 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -73,7 +73,6 @@ properties:
       - items:
           - enum:
               - renesas,scif-r9a07g044      # RZ/G2{L,LC}
-              - renesas,scif-r9a07g054      # RZ/V2L
 
       - items:
           - enum:
@@ -167,7 +166,6 @@ if:
           - renesas,rcar-gen3-scif
           - renesas,rcar-gen4-scif
           - renesas,scif-r9a07g044
-          - renesas,scif-r9a07g054
 then:
   required:
     - resets
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC
  2022-02-06 18:47 [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Biju Das
@ 2022-02-06 18:47 ` Biju Das
  2022-02-07 13:24   ` Geert Uytterhoeven
  2022-02-06 18:47 ` [PATCH 3/3] dt-bindings: serial: renesas,sci: " Biju Das
  2022-02-07 13:16 ` [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Geert Uytterhoeven
  2 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2022-02-06 18:47 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Biju Das, Geert Uytterhoeven, linux-serial, devicetree,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
	linux-renesas-soc

Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on
RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes
are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will
be used as a fallback.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/serial/renesas,scif.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index 461392091579..06e857bfd2ff 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -76,8 +76,9 @@ properties:
 
       - items:
           - enum:
+              - renesas,scif-r9a07g043      # RZ/G2UL
               - renesas,scif-r9a07g054      # RZ/V2L
-          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/V2L
+          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/{G2UL,V2L}
 
   reg:
     maxItems: 1
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] dt-bindings: serial: renesas,sci: Document RZ/G2UL SoC
  2022-02-06 18:47 [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Biju Das
  2022-02-06 18:47 ` [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC Biju Das
@ 2022-02-06 18:47 ` Biju Das
  2022-02-07 13:25   ` Geert Uytterhoeven
  2022-02-07 13:16 ` [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Geert Uytterhoeven
  2 siblings, 1 reply; 7+ messages in thread
From: Biju Das @ 2022-02-06 18:47 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring
  Cc: Biju Das, Geert Uytterhoeven, linux-serial, devicetree,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
	linux-renesas-soc

Add SCI binding documentation for Renesas RZ/G2UL SoC. No driver changes
are required as generic compatible string "renesas,sci" will be used as
a fallback.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/serial/renesas,sci.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/renesas,sci.yaml b/Documentation/devicetree/bindings/serial/renesas,sci.yaml
index 8dda4e10e09d..bf7708a7a2c0 100644
--- a/Documentation/devicetree/bindings/serial/renesas,sci.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,sci.yaml
@@ -17,6 +17,7 @@ properties:
     oneOf:
       - items:
           - enum:
+              - renesas,r9a07g043-sci     # RZ/G2UL
               - renesas,r9a07g044-sci     # RZ/G2{L,LC}
               - renesas,r9a07g054-sci     # RZ/V2L
           - const: renesas,sci            # generic SCI compatible UART
@@ -67,6 +68,7 @@ if:
     compatible:
       contains:
         enum:
+          - renesas,r9a07g043-sci
           - renesas,r9a07g044-sci
           - renesas,r9a07g054-sci
 then:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054
  2022-02-06 18:47 [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Biju Das
  2022-02-06 18:47 ` [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC Biju Das
  2022-02-06 18:47 ` [PATCH 3/3] dt-bindings: serial: renesas,sci: " Biju Das
@ 2022-02-07 13:16 ` Geert Uytterhoeven
  2 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-02-07 13:16 UTC (permalink / raw)
  To: Biju Das
  Cc: Greg Kroah-Hartman, Rob Herring, open list:SERIAL DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad, Linux-Renesas

On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> This patch removes redundant "renesas,scif-r9a07g054" from binding
> documentation as it uses renesas,scif-r9a07g044 fallback.
>
> Whilst remove the additional renesas,scif-r9a07g054 from Items.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC
  2022-02-06 18:47 ` [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC Biju Das
@ 2022-02-07 13:24   ` Geert Uytterhoeven
  2022-02-07 13:41     ` Biju Das
  0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-02-07 13:24 UTC (permalink / raw)
  To: Biju Das
  Cc: Greg Kroah-Hartman, Rob Herring, Geert Uytterhoeven,
	open list:SERIAL DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad, Linux-Renesas

Hi Biju,

On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on
> RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes
> are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will
> be used as a fallback.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -76,8 +76,9 @@ properties:
>
>        - items:
>            - enum:
> +              - renesas,scif-r9a07g043      # RZ/G2UL
>                - renesas,scif-r9a07g054      # RZ/V2L
> -          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/V2L
> +          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/{G2UL,V2L}

To avoid having to update this comment over and over again,
perhaps the "for ..." should be dropped?

The rest looks good to me.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] dt-bindings: serial: renesas,sci: Document RZ/G2UL SoC
  2022-02-06 18:47 ` [PATCH 3/3] dt-bindings: serial: renesas,sci: " Biju Das
@ 2022-02-07 13:25   ` Geert Uytterhoeven
  0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-02-07 13:25 UTC (permalink / raw)
  To: Biju Das
  Cc: Greg Kroah-Hartman, Rob Herring, open list:SERIAL DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad, Linux-Renesas

On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add SCI binding documentation for Renesas RZ/G2UL SoC. No driver changes
> are required as generic compatible string "renesas,sci" will be used as
> a fallback.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC
  2022-02-07 13:24   ` Geert Uytterhoeven
@ 2022-02-07 13:41     ` Biju Das
  0 siblings, 0 replies; 7+ messages in thread
From: Biju Das @ 2022-02-07 13:41 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Greg Kroah-Hartman, Rob Herring, Geert Uytterhoeven,
	open list:SERIAL DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Prabhakar Mahadev Lad, Linux-Renesas

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document
> RZ/G2UL SoC
> 
> Hi Biju,
> 
> On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on
> > RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes
> > are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will
> > be used as a fallback.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -76,8 +76,9 @@ properties:
> >
> >        - items:
> >            - enum:
> > +              - renesas,scif-r9a07g043      # RZ/G2UL
> >                - renesas,scif-r9a07g054      # RZ/V2L
> > -          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for
> RZ/V2L
> > +          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for
> RZ/{G2UL,V2L}
> 
> To avoid having to update this comment over and over again, perhaps the
> "for ..." should be dropped?

Agreed, Will drop "for ..." in next version.

Regards,
Biju

> 
> The rest looks good to me.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-02-07 13:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-06 18:47 [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Biju Das
2022-02-06 18:47 ` [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC Biju Das
2022-02-07 13:24   ` Geert Uytterhoeven
2022-02-07 13:41     ` Biju Das
2022-02-06 18:47 ` [PATCH 3/3] dt-bindings: serial: renesas,sci: " Biju Das
2022-02-07 13:25   ` Geert Uytterhoeven
2022-02-07 13:16 ` [PATCH 1/3] dt-bindings: serial: renesas,scif: Remove redundant renesas,scif-r9a07g054 Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).