devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] arm64: dts: renesas: r8a774a1: put I2C aliases to board files
Date: Fri, 26 Aug 2022 16:51:47 +0200	[thread overview]
Message-ID: <CAMuHMdVMZf80hVE6YbsVxxByJQ3onJKk5KwVvB=+PaQkahRAVQ@mail.gmail.com> (raw)
In-Reply-To: <20220825071022.7864-7-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Thu, Aug 25, 2022 at 9:11 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> I2C aliases are not a property of a SoC. They belong to board files
> where they are named accordingly in the schematics.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -10,6 +10,14 @@
>
>  / {
>         aliases {
> +               i2c0 = &i2c0;
> +               i2c1 = &i2c1;
> +               i2c2 = &i2c2;
> +               i2c3 = &i2c3;
> +               i2c4 = &i2c4;
> +               i2c5 = &i2c5;
> +               i2c6 = &i2c6;
> +               i2c7 = &iic_pmic;
>                 serial0 = &scif2;
>                 serial1 = &hscif0;
>                 mmc0 = &sdhi3;

Oops:

    arch/arm64/boot/dts/renesas/hihope-common.dtsi:12.10-26.4: ERROR
(path_references): /aliases: Reference to non-existent node or label
"iic_pmic"

I've sent a fix: "[PATCH] arm64: dts: renesas: r8a774e1: Rename i2c_dvfs
to iic_pmic"
https://lore.kernel.org/r/7d60653d4d63904dc025a133297a53eb885fa064.1661525361.git.geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2022-08-26 14:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  7:10 [PATCH v2 0/6] arm64: dts: renesas: move I2C aliases to board files Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 1/6] arm64: dts: renesas: r8a779{51|60|65}: put " Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 2/6] arm64: dts: renesas: r8a77970: " Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 3/6] arm64: dts: renesas: r8a77980: " Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 4/6] arm64: dts: renesas: r8a77990: " Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 5/6] arm64: dts: renesas: r8a779a0: " Wolfram Sang
2022-08-25  7:10 ` [PATCH v2 6/6] arm64: dts: renesas: r8a774a1: " Wolfram Sang
2022-08-26 14:51   ` Geert Uytterhoeven [this message]
2022-08-26 14:54 ` [PATCH v2 0/6] arm64: dts: renesas: move " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVMZf80hVE6YbsVxxByJQ3onJKk5KwVvB=+PaQkahRAVQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).