From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33024C433FE for ; Tue, 8 Mar 2022 10:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346022AbiCHKyv (ORCPT ); Tue, 8 Mar 2022 05:54:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346017AbiCHKyu (ORCPT ); Tue, 8 Mar 2022 05:54:50 -0500 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECC1041303; Tue, 8 Mar 2022 02:53:53 -0800 (PST) Received: by mail-qk1-f182.google.com with SMTP id q194so720807qke.5; Tue, 08 Mar 2022 02:53:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y3UjhnfNllI0p7H4Pz4n1OpkqRIkGKtHIsAtcWmQ56k=; b=wVHo5IQ5bciRSAK0P1M09x6mXHwaDOhfHfSGVE7HnYRYSs8WMMSRJAevSGGA8CmSdj O7v/i1pSIl5ROilAe8XMd51r6D7irrPDX8HlU9jdfuFjlsL9zdNoBqtAvZBTG8NFXiPl ozZosREixJ7X703acFawjiuztlP2BOSKtwyGoaDzVKY9ROCTtuj6XPFgrcrW/p9vAcHu vsN3NpOgLQVnQ1c8KPWkpv6dIWM1mdN8PZzttfhhCh2T7CkC1Q80HORK3ip4QDkchMVL qPlk7p7DAXv8WyithiJvif5fDegJEGbp+1JzAcNtLe6njEjFRSJXJlOM74J6B5xO0mi0 GhUA== X-Gm-Message-State: AOAM530Psmd0RiXDuKZA+f6oz6WnsmVADtWrZYpASFRWNKdFzCLR1f85 v4/Dd0CDgEPyFjZuxsxtNa9XKyiicv57xA== X-Google-Smtp-Source: ABdhPJyaD6taEO+1bVn3Egmp6kNMQdMy0Ml9Ar+8QirDSJHZvhJ4Kp4/462N9EEFattiblNPh5ZoTQ== X-Received: by 2002:a05:620a:2589:b0:67b:d0c:71bc with SMTP id x9-20020a05620a258900b0067b0d0c71bcmr8343413qko.570.1646736832493; Tue, 08 Mar 2022 02:53:52 -0800 (PST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com. [209.85.128.171]) by smtp.gmail.com with ESMTPSA id z3-20020ac87f83000000b002deae661c08sm10069704qtj.33.2022.03.08.02.53.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 02:53:51 -0800 (PST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2dbc48104beso196634157b3.5; Tue, 08 Mar 2022 02:53:51 -0800 (PST) X-Received: by 2002:a81:618b:0:b0:2db:d952:8a39 with SMTP id v133-20020a81618b000000b002dbd9528a39mr12190538ywb.132.1646736830798; Tue, 08 Mar 2022 02:53:50 -0800 (PST) MIME-Version: 1.0 References: <20220124121009.108649-1-alistair@alistair23.me> <20220124121009.108649-3-alistair@alistair23.me> In-Reply-To: <20220124121009.108649-3-alistair@alistair23.me> From: Geert Uytterhoeven Date: Tue, 8 Mar 2022 11:53:39 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v18 2/8] mfd: simple-mfd-i2c: Add a Kconfig name To: Alistair Francis Cc: Mark Brown , Rob Herring , Sascha Hauer , Liam Girdwood , Lee Jones , Linux PM list , linux-hwmon@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , NXP Linux Team , Zhang Rui , alistair23@gmail.com, Amit Kucheria , Linux ARM , Andreas Kemnade , Sascha Hauer , Linux Kernel Mailing List , Shawn Guo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alistair, Thanks for your patch, which is now commit bae5a4acef67db88 ("mfd: simple-mfd-i2c: Add a Kconfig name") in mfd/for-mfd-next. On Mon, Jan 24, 2022 at 1:24 PM Alistair Francis wrote: > Add a Kconfig name to the "Simple Multi-Functional Device support (I2C)" > device so that it can be enabled via menuconfig. Which still does not explain why this would be needed... > Signed-off-by: Alistair Francis > Acked-for-MFD-by: Lee Jones > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1188,7 +1188,7 @@ config MFD_SI476X_CORE > module will be called si476x-core. > > config MFD_SIMPLE_MFD_I2C > - tristate > + tristate "Simple Multi-Functional Device support (I2C)" > depends on I2C > select MFD_CORE > select REGMAP_I2C The help text states: | This driver creates a single register map with the intention for it | to be shared by all sub-devices. Yes, that's what MFD does? | Once the register map has been successfully initialised, any | sub-devices represented by child nodes in Device Tree will be | subsequently registered. OK...? Still, no clue about what this driver really does, and why and when it would be needed. There is one driver symbol that selects MFD_SIMPLE_MFD_I2C. There are no driver symbols that depend on this symbol. If you have a driver in the pipeline that can make use of this, can't it just select MFD_SIMPLE_MFD_I2C, so the symbol itself can stay invisible? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds