Re: [PATCH v2] arm64: dts: renesas: white-hawk: ethernet: Describe avb1 and avb2

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Niklas,

Thanks for your patch!

On Sat, Mar 9, 2024 at 4:56 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Describe the two Marvel 88Q2110/QFN40 PHYs available on the R-Car V4H

Marvell (apparently the schematics author spent too much time with
Spiderman and friends ;-)

> White Hawk RAVB/Ethernet(1000Base-T1) sub-board. The two PHYs are wired
> up on the board by default, there is no need to move any resistors which
> are needed to access other PHYs available on this sub-board.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-ethernet.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-ethernet.dtsi

That is arch/arm64/boot/dts/renesas/white-hawk-ethernet.dtsi, as of
commit 1b940d036d5a2235 ("arm64: dts: renesas: white-hawk: Drop SoC
parts from sub boards").

> @@ -6,6 +6,50 @@
>   * Copyright (C) 2022 Glider bv
>   */
>
> +&avb1 {
> +       pinctrl-0 = <&avb1_pins>;
> +       pinctrl-names = "default";
> +       phy-handle = <&phy1>;
> +       status = "okay";
> +
> +       mdio {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               reset-gpios = <&gpio6 1 GPIO_ACTIVE_LOW>;
> +               reset-post-delay-us = <4000>;
> +
> +               phy1: ethernet-phy@0 {

Given the large number of PHYs on the White-Hawk board stack, I think
a more specific name would be more suitable, e.g. "avb1-phy"?
Same for AVB2 below.

> +                       compatible = "ethernet-phy-ieee802.3-c45";
> +                       reg = <0>;
> +                       interrupt-parent = <&gpio6>;
> +                       interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +               };
> +       };
> +};

Probably we also want "ethernet1" and "ethernet2" aliases, so U-Boot
can fill in the corresponding MAC addresses?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds