[PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[Jiada Wang]

According to user reference manual for R-CAR H3 and M3-W SoCs,
in order to access busif4 ~ busif7, extended audio dmac registers
(PDMASAREn, PDMADAREn, PDMACHCREn)
need to be used, rather than basic audio dmac registers
(PDMASARn, PDMADARn, PDMACHCRn)

This patch set updates H3 (= r8a7795) and M3-W (= r8a7796) 
to use extended audio dmac registers

Jiada Wang (2):
  arm64: dts: renesas: r8a7795: use extended audio dmac register
  arm64: dts: renesas: r8a7796: use extended audio dmac register

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.19.2

[PATCH v1 1/2] arm64: dts: renesas: r8a7795: use extended audio dmac register

[Jiada Wang]

Basic audio dmac register only supports busif from 0 to 3,
in order to use busif4 ~ busif7, extended audio dmac register
need to be used.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index af9605d5db27..3adf0663451a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1836,7 +1836,7 @@
 				<0 0xec5a0000 0 0x100>,  /* ADG */
 				<0 0xec540000 0 0x1000>, /* SSIU */
 				<0 0xec541000 0 0x280>,  /* SSI */
-				<0 0xec740000 0 0x200>;  /* Audio DMAC peri peri*/
+				<0 0xec760000 0 0x200>;  /* Audio DMAC peri peri*/
 			reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
 
 			clocks = <&cpg CPG_MOD 1005>,
-- 
2.19.2

Re: [PATCH v1 1/2] arm64: dts: renesas: r8a7795: use extended audio dmac register

[Geert Uytterhoeven]

On Wed, Feb 20, 2019 at 6:25 AM Jiada Wang <jiada_wang@mentor.com> wrote:
> Basic audio dmac register only supports busif from 0 to 3,
> in order to use busif4 ~ busif7, extended audio dmac register
> need to be used.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
but please consider my comments to the cover letter.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v1 2/2] arm64: dts: renesas: r8a7796: use extended audio dmac register

[Jiada Wang]

Basic audio dmac register only supports busif from 0 to 3,
in order to use busif4 ~ busif7, extended audio dmac register
need to be used

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0648d12778ed..1ca487480c79 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1775,7 +1775,7 @@
 				<0 0xec5a0000 0 0x100>,  /* ADG */
 				<0 0xec540000 0 0x1000>, /* SSIU */
 				<0 0xec541000 0 0x280>,  /* SSI */
-				<0 0xec740000 0 0x200>;  /* Audio DMAC peri peri*/
+				<0 0xec760000 0 0x200>;  /* Audio DMAC peri peri*/
 			reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
 
 			clocks = <&cpg CPG_MOD 1005>,
-- 
2.19.2

Re: [PATCH v1 2/2] arm64: dts: renesas: r8a7796: use extended audio dmac register

[Geert Uytterhoeven]

On Wed, Feb 20, 2019 at 6:25 AM Jiada Wang <jiada_wang@mentor.com> wrote:
> Basic audio dmac register only supports busif from 0 to 3,
> in order to use busif4 ~ busif7, extended audio dmac register
> need to be used
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
but please consider my comments to the cover letter.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[Geert Uytterhoeven]

Hi Jiada,

On Wed, Feb 20, 2019 at 6:25 AM Jiada Wang <jiada_wang@mentor.com> wrote:
> According to user reference manual for R-CAR H3 and M3-W SoCs,
> in order to access busif4 ~ busif7, extended audio dmac registers
> (PDMASAREn, PDMADAREn, PDMACHCREn)
> need to be used, rather than basic audio dmac registers
> (PDMASARn, PDMADARn, PDMACHCRn)
>
> This patch set updates H3 (= r8a7795) and M3-W (= r8a7796)
> to use extended audio dmac registers

The same change should be applied for M3-N and RZ/G2M, right?

R-Car E3 and RZ/G2E already use the extended register set, as they do not
have the basic set.

For SoCs having both, this feels a bit like describing software policy, instead
of hardware, to me. Would it make sense to extend the audio bindings, and
allow describing both the basic and extended register sets, and let the driver
make the decision which one to use?

Thanks!

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[Kuninori Morimoto]

Hi Geert

> > According to user reference manual for R-CAR H3 and M3-W SoCs,
> > in order to access busif4 ~ busif7, extended audio dmac registers
> > (PDMASAREn, PDMADAREn, PDMACHCREn)
> > need to be used, rather than basic audio dmac registers
> > (PDMASARn, PDMADARn, PDMACHCRn)
> >
> > This patch set updates H3 (= r8a7795) and M3-W (= r8a7796)
> > to use extended audio dmac registers
> 
> The same change should be applied for M3-N and RZ/G2M, right?
> 
> R-Car E3 and RZ/G2E already use the extended register set, as they do not
> have the basic set.
> 
> For SoCs having both, this feels a bit like describing software policy, instead
> of hardware, to me. Would it make sense to extend the audio bindings, and
> allow describing both the basic and extended register sets, and let the driver
> make the decision which one to use?

I don't think we need to use basic register.
This means extended register only is very enough.
I'm not sure why datasheet is indicating basic...

Best regards
---
Kuninori Morimoto

Re: [PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[jiada]

Hi Geert


On 2019/02/20 17:10, Kuninori Morimoto wrote:
> 
> Hi Geert
> 
>>> According to user reference manual for R-CAR H3 and M3-W SoCs,
>>> in order to access busif4 ~ busif7, extended audio dmac registers
>>> (PDMASAREn, PDMADAREn, PDMACHCREn)
>>> need to be used, rather than basic audio dmac registers
>>> (PDMASARn, PDMADARn, PDMACHCRn)
>>>
>>> This patch set updates H3 (= r8a7795) and M3-W (= r8a7796)
>>> to use extended audio dmac registers
>>
>> The same change should be applied for M3-N and RZ/G2M, right?
>>
Currently only H3 and M3-W support to use busif other than busif0,
I feel currently it's only necessary to use extended audio dmac register 
for these SoCs

>> R-Car E3 and RZ/G2E already use the extended register set, as they do not
>> have the basic set.
>>
>> For SoCs having both, this feels a bit like describing software policy, instead
>> of hardware, to me. Would it make sense to extend the audio bindings, and
>> allow describing both the basic and extended register sets, and let the driver
>> make the decision which one to use?
> 
> I don't think we need to use basic register.
> This means extended register only is very enough.
> I'm not sure why datasheet is indicating basic...
> 
Extended audio dmac registers covers all function of basic ones,
so there is no need to use basic registers

Thanks,
Jiada

> Best regards
> ---
> Kuninori Morimoto
> 

Re: [PATCH v1 0/2] rsnd: dts: change to use extended audio dmac register

[Simon Horman]

On Fri, Feb 22, 2019 at 12:05:02PM +0900, jiada wrote:
> Hi Geert
> 
> 
> On 2019/02/20 17:10, Kuninori Morimoto wrote:
> > 
> > Hi Geert
> > 
> > > > According to user reference manual for R-CAR H3 and M3-W SoCs,
> > > > in order to access busif4 ~ busif7, extended audio dmac registers
> > > > (PDMASAREn, PDMADAREn, PDMACHCREn)
> > > > need to be used, rather than basic audio dmac registers
> > > > (PDMASARn, PDMADARn, PDMACHCRn)
> > > > 
> > > > This patch set updates H3 (= r8a7795) and M3-W (= r8a7796)
> > > > to use extended audio dmac registers
> > > 
> > > The same change should be applied for M3-N and RZ/G2M, right?
> > > 
> Currently only H3 and M3-W support to use busif other than busif0,
> I feel currently it's only necessary to use extended audio dmac register for
> these SoCs
> 
> > > R-Car E3 and RZ/G2E already use the extended register set, as they do not
> > > have the basic set.
> > > 
> > > For SoCs having both, this feels a bit like describing software policy, instead
> > > of hardware, to me. Would it make sense to extend the audio bindings, and
> > > allow describing both the basic and extended register sets, and let the driver
> > > make the decision which one to use?
> > 
> > I don't think we need to use basic register.
> > This means extended register only is very enough.
> > I'm not sure why datasheet is indicating basic...
> > 
> Extended audio dmac registers covers all function of basic ones,
> so there is no need to use basic registers

This still sounds a lot like a policy decision that should
be made by the driver based on a fuller description of the hardware
in DT.