From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 35/44] m68k: Register with kernel poweroff handler Date: Tue, 7 Oct 2014 11:19:36 +0200 Message-ID: References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-36-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1412659726-29957-36-git-send-email-linux@roeck-us.net> Sender: linux-m68k-owner@vger.kernel.org To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "adi-buildroot-devel@lists.sourceforge.net" , driverdevel , "devicetree@vger.kernel.org" , lguest@lists.ozlabs.org, ACPI Devel Maling List , alpha , "moderated list:PANASONIC MN10300..." , Cris , linux-efi@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , linux-m32r-ja@ml.linux-m32r.org, "linuxppc-dev@lists.ozlabs.org" , linux-s390 , linux-tegra@vger.kernel.org, "linux-xtensa@linux-xtensa.org" , openipmi-developer@lists.sourceforge.net, uml-devel List-Id: devicetree@vger.kernel.org On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote: > Register with kernel poweroff handler instead of setting pm_power_off > directly. > > Cc: Geert Uytterhoeven > Cc: Joshua Thompson > Signed-off-by: Guenter Roeck As someone already mentioned, having #defines instead of hardcoded numbers for the priorities would be nice. Apart from that: Acked-by: Geert Uytterhoeven > + register_poweroff_handler_simple(nf_poweroff, 128); > + register_poweroff_handler_simple(mac_poweroff, 128); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds