From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] ARM: dts: iwg20d-q7: Add pinctl support for scif0 Date: Mon, 19 Jun 2017 10:42:18 +0200 Message-ID: References: <1497625049-46802-1-git-send-email-biju.das@bp.renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1497625049-46802-1-git-send-email-biju.das@bp.renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Biju Das Cc: Rob Herring , Mark Rutland , Simon Horman , Magnus Damm , Russell King , Chris Paterson , "devicetree@vger.kernel.org" , Linux-Renesas , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Biju, On Fri, Jun 16, 2017 at 4:57 PM, Biju Das wrote: > Adding pinctrl support for scif0 interface. > > Signed-off-by: Biju Das The patch looks good to me, but without schematics, we cannot verify the actual pins used. Are the schematics somewhere available? Having access to them would allow us doing a better job reviewing your DTS patches. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds