[PATCH 0/5] Add EPSON RX-8571 RTC support

[PATCH 0/5] Add EPSON RX-8571 RTC support

[Biju Das]

This patch set aims to add support for EPSON RX-8571 real-time clock.
EPSON RX-8571 rtc is compatible with EPSON RX-8581 rtc except that
former has 16 bytes additional RAM.

1 byte of nvmem is supported on both RX-8581 and RX-8571. It is
exposed through sysfs along with  support for 16 bytes additional RAM
present only on EPSON RX-8571.

This patch series is tested against renesas-dev and linux-next.

Biju Das (5):
  rtc: rx8581: Add rx8571 compatible
  rtc: rx8581: Add support for rx8571 RTC
  rtc: rx8581: Add support for Epson rx8571 RTC
  arm64: defconfig: enable RX-8581 config option
  arm64: dts: renesas: r8a774c0-cat874: add RTC support

 Documentation/devicetree/bindings/rtc/rtc.txt   |   1 +
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts |  18 ++++
 arch/arm64/configs/defconfig                    |   1 +
 drivers/rtc/Kconfig                             |   5 +-
 drivers/rtc/rtc-rx8581.c                        | 114 ++++++++++++++++++++++--
 5 files changed, 128 insertions(+), 11 deletions(-)

-- 
2.7.4

[PATCH 1/5] rtc: rx8581: Add rx8571 compatible

[Biju Das]

The Epson rx8571 is compatible with the Epson rx8581 RTC.

The difference between the rx8571 and rx8581 RTC is that the former has
16 bytes more RAM. This renders them incompatible from a DT point of view.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/rtc/rtc.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt
index 3e6a215..0bc687e 100644
--- a/Documentation/devicetree/bindings/rtc/rtc.txt
+++ b/Documentation/devicetree/bindings/rtc/rtc.txt
@@ -47,6 +47,7 @@ dallas,ds1374		I2C, 32-Bit Binary Counter Watchdog RTC with Trickle Charger and
 dallas,ds1672		Dallas DS1672 Real-time Clock
 dallas,ds3232		Extremely Accurate I²C RTC with Integrated Crystal and SRAM
 epson,rx8010		I2C-BUS INTERFACE REAL TIME CLOCK MODULE
+epson,rx8571		I2C-BUS INTERFACE REAL TIME CLOCK MODULE with Battery Backed RAM
 epson,rx8581		I2C-BUS INTERFACE REAL TIME CLOCK MODULE
 emmicro,em3027		EM Microelectronic EM3027 Real-time Clock
 isil,isl1208		Intersil ISL1208 Low Power RTC with Battery Backed SRAM
-- 
2.7.4

[PATCH 5/5] arm64: dts: renesas: r8a774c0-cat874: add RTC support

[Biju Das]

This patch adds Epson RX-8571 real time clock support.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index 96ee0d2c..18ff79c 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -56,6 +56,19 @@
 	clock-frequency = <48000000>;
 };
 
+&i2c1 {
+	pinctrl-0 = <&i2c1_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	clock-frequency = <400000>;
+
+	rtc@32 {
+		compatible = "epson,rx8571";
+		reg = <0x32>;
+	};
+};
+
 &pcie_bus_clk {
 	clock-frequency = <100000000>;
 };
@@ -66,6 +79,11 @@
 };
 
 &pfc {
+	i2c1_pins: i2c1 {
+		groups = "i2c1_b";
+		function = "i2c1";
+	};
+
 	scif2_pins: scif2 {
 		groups = "scif2_data_a";
 		function = "scif2";
-- 
2.7.4

Re: [PATCH 5/5] arm64: dts: renesas: r8a774c0-cat874: add RTC support

[Geert Uytterhoeven]

On Thu, Feb 21, 2019 at 10:46 AM Biju Das <biju.das@bp.renesas.com> wrote:
> This patch adds Epson RX-8571 real time clock support.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/5] Add EPSON RX-8571 RTC support

[Alexandre Belloni]

On 21/02/2019 09:40:43+0000, Biju Das wrote:
> This patch set aims to add support for EPSON RX-8571 real-time clock.
> EPSON RX-8571 rtc is compatible with EPSON RX-8581 rtc except that
> former has 16 bytes additional RAM.
> 
> 1 byte of nvmem is supported on both RX-8581 and RX-8571. It is
> exposed through sysfs along with  support for 16 bytes additional RAM
> present only on EPSON RX-8571.
> 
> This patch series is tested against renesas-dev and linux-next.
> 
> Biju Das (5):
>   rtc: rx8581: Add rx8571 compatible
>   rtc: rx8581: Add support for rx8571 RTC
>   rtc: rx8581: Add support for Epson rx8571 RTC

Applied 1-3. Note that I squashed 2 and 3 as 2 didn't make much sense
without 3.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

RE: [PATCH 0/5] Add EPSON RX-8571 RTC support

[Biju Das]

Hi Alexandre,

> -----Original Message-----
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Sent: 02 March 2019 21:08
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; linux-
> rtc@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman
> <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>;
> Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; linux-renesas-soc@vger.kernel.org
> Subject: Re: [PATCH 0/5] Add EPSON RX-8571 RTC support
>
> On 21/02/2019 09:40:43+0000, Biju Das wrote:
> > This patch set aims to add support for EPSON RX-8571 real-time clock.
> > EPSON RX-8571 rtc is compatible with EPSON RX-8581 rtc except that
> > former has 16 bytes additional RAM.
> >
> > 1 byte of nvmem is supported on both RX-8581 and RX-8571. It is
> > exposed through sysfs along with  support for 16 bytes additional RAM
> > present only on EPSON RX-8571.
> >
> > This patch series is tested against renesas-dev and linux-next.
> >
> > Biju Das (5):
> >   rtc: rx8581: Add rx8571 compatible
> >   rtc: rx8581: Add support for rx8571 RTC
> >   rtc: rx8581: Add support for Epson rx8571 RTC
>
> Applied 1-3. Note that I squashed 2 and 3 as 2 didn't make much sense
> without 3.

Thanks.

Regards,
Biju


Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH 5/5] arm64: dts: renesas: r8a774c0-cat874: add RTC support

[Simon Horman]

On Fri, Mar 01, 2019 at 11:29:21AM +0100, Geert Uytterhoeven wrote:
> On Thu, Feb 21, 2019 at 10:46 AM Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch adds Epson RX-8571 real time clock support.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v5.2.