Re: [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB

[Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>]

On Wed, Aug 31, 2016 at 12:02 PM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> This supports Ethernet AVB on H3ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts

> @@ -62,3 +68,29 @@
>         clock-frequency = <14745600>;
>         status = "okay";
>  };
> +
> +&avb {
> +       pinctrl-0 = <&avb_pins>;
> +       pinctrl-names = "default";
> +       renesas,no-ether-link;
> +       phy-handle = <&phy0>;
> +       status = "okay";
> +
> +       phy0: ethernet-phy@0 {
> +               rxc-skew-ps = <900>;
> +               rxdv-skew-ps = <0>;
> +               rxd0-skew-ps = <0>;
> +               rxd1-skew-ps = <0>;
> +               rxd2-skew-ps = <0>;
> +               rxd3-skew-ps = <0>;
> +               txc-skew-ps = <900>;
> +               txen-skew-ps = <0>;
> +               txd0-skew-ps = <0>;
> +               txd1-skew-ps = <0>;
> +               txd2-skew-ps = <0>;
> +               txd3-skew-ps = <0>;
> +               reg = <0>;
> +               interrupt-parent = <&gpio2>;
> +               interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

Just wondering (it's done the same way on Salvator-X) why this is using a
GPIO interrupt, and not the dedicated AVB_PHY_INT?

> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html