From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname Date: Wed, 20 Apr 2016 08:51:23 +0200 Message-ID: References: <1460381349-14408-1-git-send-email-kernel@martin.sperl.org> <1460381349-14408-3-git-send-email-kernel@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1460381349-14408-3-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martin Sperl Cc: Rob Herring , Mark Rutland , Stephen Warren , Lee Jones , Eric Anholt , Russell King , Vinod Koul , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Apr 11, 2016 at 3:29 PM, wrote: > From: Martin Sperl > > Use platform_get_irq_byname to allow for correct mapping of > interrupts to dma channels. > > The currently implemented device tree is unfortunately > implemented with the wrong assumption, that each dma-channel > has its own dma channel, but dma-irq 11 is handling > dma-channel 11-14 and dma-irq 12 is actually a "catch all" > interrupt. > > So here we use the byname variant and require that interrupts > are explicitly named via the interrupts-name property in the interrupt-names > device tree. > > The use of shared interrupts is also implemented. You're not explicitly looking for "dma-shared-all" for that? You might as well just declare a single unnamed interrupt in the bindings. > + /* legacy device tree case handling */ > + dev_warn_once(&pdev->dev, > + "missing interrupts-names property in device tree - legacy interpretation is used"); interrupt-names Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html