devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-mtd@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode
Date: Fri, 13 Nov 2015 08:56:18 +0100	[thread overview]
Message-ID: <CAMuHMdW4jOYJJvk8RX+uZRhsa=eT3hg+by_3rbKP96M1mrLjPQ@mail.gmail.com> (raw)
In-Reply-To: <20151113002820.GE20462@verge.net.au>

Hi Simon,

On Fri, Nov 13, 2015 at 1:28 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote:
>> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote:
>> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a
>> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
>> >> partitions in a special 'partitions' subnode"), having partitions as
>> >> direct subnodes of an mtd device is discouraged:
>> >>
>> >>     spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions.
>> >
>> > I seem to see something else, perhaps I have a hardware problem?
>> >
>> >      m25p80 spi0.0: unrecognized JEDEC id bytes: 01,  2, 20
>>
>> That indeed means QSPI doesn't work. Is it reproducible?
>> Is this on Koelsch?
>
> Yes. It appears to happy reliably in my Koelsch.

Which tree / config?

I've just tried renesas-devel-20151113-v4.3 and topic/gen3-latest with
shmobile_defconfig, and the QSPI flash was detected correctly on both (the
former failed to parse partitions, as the code for the partitions subnode is
not yet in v4.3).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2015-11-13  7:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10  8:35 [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode Geert Uytterhoeven
2015-11-12  1:15 ` Simon Horman
     [not found]   ` <20151112011522.GB19649-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-11-12 10:03     ` Geert Uytterhoeven
2015-11-13  0:28       ` Simon Horman
2015-11-13  7:56         ` Geert Uytterhoeven [this message]
2015-11-17 17:46           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdW4jOYJJvk8RX+uZRhsa=eT3hg+by_3rbKP96M1mrLjPQ@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-mtd@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).