From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode Date: Fri, 13 Nov 2015 08:56:18 +0100 Message-ID: References: <1447144506-20336-1-git-send-email-geert+renesas@glider.be> <20151112011522.GB19649@verge.net.au> <20151113002820.GE20462@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151113002820.GE20462@verge.net.au> Sender: linux-sh-owner@vger.kernel.org To: Simon Horman Cc: Geert Uytterhoeven , Magnus Damm , Linux-sh list , "devicetree@vger.kernel.org" , linux-mtd@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Simon, On Fri, Nov 13, 2015 at 1:28 AM, Simon Horman wrote: > On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman wrote: >> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: >> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a >> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support >> >> partitions in a special 'partitions' subnode"), having partitions as >> >> direct subnodes of an mtd device is discouraged: >> >> >> >> spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. >> > >> > I seem to see something else, perhaps I have a hardware problem? >> > >> > m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 >> >> That indeed means QSPI doesn't work. Is it reproducible? >> Is this on Koelsch? > > Yes. It appears to happy reliably in my Koelsch. Which tree / config? I've just tried renesas-devel-20151113-v4.3 and topic/gen3-latest with shmobile_defconfig, and the QSPI flash was detected correctly on both (the former failed to parse partitions, as the code for the partitions subnode is not yet in v4.3). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds