From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Robin van der Gracht <robin@protonic.nl>,
Rob Herring <robh+dt@kernel.org>,
Paul Burton <paulburton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>, Marek Behun <marek.behun@nic.cz>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-leds <linux-leds@vger.kernel.org>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string
Date: Wed, 20 Oct 2021 10:27:36 +0200 [thread overview]
Message-ID: <CAMuHMdWBhBs3dpLFHo8VmUr22DkbXpPqMSwqkCVzpYYNA-5g4A@mail.gmail.com> (raw)
In-Reply-To: <CANiq72nGPzDEeiQccTQ6QCeionfkfp01EDjp4btBfYKabXzGrg@mail.gmail.com>
Hi Miguel,
On Tue, Oct 19, 2021 at 11:09 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Tue, Oct 19, 2021 at 10:50 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > Unrelated to this patch (and no need to change it), but we could
> > remove the conditional guarding the devm_kfree below to match this
> > one.
>
> Yeah, you did it when moving the code later on -- I guess we could
> have done it before too, to match, like the sysfs_emit change does it
> before, but it is not that important.
As this patch fixes a DoS that can be triggered from userspace,
I wanted it to be a fix as small and concise as possible.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-10-20 8:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 14:44 [PATCH v8 00/21] auxdisplay: ht16k33: Add character display support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 01/21] uapi: Add <linux/map_to_14segment.h> Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 02/21] dt-bindings: auxdisplay: ht16k33: Document Adafruit segment displays Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 03/21] auxdisplay: img-ascii-lcd: Fix lock-up when displaying empty string Geert Uytterhoeven
2021-10-19 20:50 ` Miguel Ojeda
2021-10-19 21:09 ` Miguel Ojeda
2021-10-20 8:27 ` Geert Uytterhoeven [this message]
2021-10-19 14:45 ` [PATCH v8 04/21] auxdisplay: img-ascii-lcd: Add helper variable dev Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 05/21] auxdisplay: img-ascii-lcd: Convert device attribute to sysfs_emit() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 06/21] auxdisplay: Extract character line display core support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 07/21] auxdisplay: linedisp: Use kmemdup_nul() helper Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 08/21] auxdisplay: linedisp: Add support for changing scroll rate Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 09/21] auxdisplay: ht16k33: Connect backlight to fbdev Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 10/21] auxdisplay: ht16k33: Fix frame buffer device blanking Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 11/21] auxdisplay: ht16k33: Use HT16K33_FB_SIZE in ht16k33_initialize() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 12/21] auxdisplay: ht16k33: Remove unneeded error check in keypad probe() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 13/21] auxdisplay: ht16k33: Convert to simple i2c probe function Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 14/21] auxdisplay: ht16k33: Add helper variable dev Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 15/21] auxdisplay: ht16k33: Move delayed work Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 16/21] auxdisplay: ht16k33: Extract ht16k33_brightness_set() Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 17/21] auxdisplay: ht16k33: Extract frame buffer probing Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 18/21] auxdisplay: ht16k33: Add support for segment displays Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 19/21] dt-bindings: auxdisplay: ht16k33: Document LED subnode Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 20/21] auxdisplay: ht16k33: Add LED support Geert Uytterhoeven
2021-10-19 14:45 ` [PATCH v8 21/21] auxdisplay: ht16k33: Make use of device properties Geert Uytterhoeven
2021-10-19 16:44 ` [PATCH v8 00/21] auxdisplay: ht16k33: Add character display support Miguel Ojeda
2021-10-21 21:57 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWBhBs3dpLFHo8VmUr22DkbXpPqMSwqkCVzpYYNA-5g4A@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=paulburton@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).