Re: [net-next,PATCH v2] dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as compatible strings

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Marek,

On Tue, Jun 25, 2024 at 8:46 PM Marek Vasut <marex@denx.de> wrote:
> Extract known PHY IDs from Linux kernel realtek PHY driver
> and convert them into supported compatible string list for
> this DT binding document.
>
> Signed-off-by: Marek Vasut <marex@denx.de>

Thanks for your patch, which is now commit 8fda53719a596fa2
("dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as
compatible strings") in net-next/main (next-20240628 and later).

> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -18,6 +18,29 @@ allOf:
>    - $ref: ethernet-phy.yaml#
>
>  properties:
> +  compatible:
> +    enum:
> +      - ethernet-phy-id001c.c800
> +      - ethernet-phy-id001c.c816
> +      - ethernet-phy-id001c.c838
> +      - ethernet-phy-id001c.c840
> +      - ethernet-phy-id001c.c848
> +      - ethernet-phy-id001c.c849
> +      - ethernet-phy-id001c.c84a
> +      - ethernet-phy-id001c.c862
> +      - ethernet-phy-id001c.c878
> +      - ethernet-phy-id001c.c880
> +      - ethernet-phy-id001c.c910
> +      - ethernet-phy-id001c.c912
> +      - ethernet-phy-id001c.c913
> +      - ethernet-phy-id001c.c914
> +      - ethernet-phy-id001c.c915
> +      - ethernet-phy-id001c.c916
> +      - ethernet-phy-id001c.c942
> +      - ethernet-phy-id001c.c961
> +      - ethernet-phy-id001c.cad0
> +      - ethernet-phy-id001c.cb00

Can you please elaborate why you didn't add an
"ethernet-phy-ieee802.3-c22" fallback?

> +
>    realtek,clkout-disable:
>      type: boolean
>      description:

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds