From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BDEBC54EE9 for ; Thu, 1 Sep 2022 10:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234201AbiIAK0G (ORCPT ); Thu, 1 Sep 2022 06:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233865AbiIAKZs (ORCPT ); Thu, 1 Sep 2022 06:25:48 -0400 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 791459F75A; Thu, 1 Sep 2022 03:25:42 -0700 (PDT) Received: by mail-qt1-f178.google.com with SMTP id w28so12998529qtc.7; Thu, 01 Sep 2022 03:25:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jQiwC2wtAwOaQD0hPRp2nlHKTvtSxYoVlYqx7E4G0+s=; b=sVJbv02cHu/phK05kLcIKg4I8etuzfFSG4AM+LaNh6NwpZs5ggmdCKvyEn3F2ftlEe S486K92bt8PGjO4YMiSZKv5w33xioDt9fB8B6U+NYRJI3h50tcm7ezUT9cJtT7R02Tjf qk/ALhacDEm04OtaEyl7ItZ2zT3fZSE7lXiuSV5wZ6p60OSvwWbOdgjxxH5dQLfzUr2h AegwkGDlFNMA3j9mBZ57l4Payoz2cDQ0DcgCvTDaia1r4rbBTtue+eixJUy3NWTnCGCp dA2hSGPIol2Ff3ujyByVuZEPl7mBl66PeMIKROEqQ1evw1A2C1n/S+psa0RVVi+yfePN 2T6Q== X-Gm-Message-State: ACgBeo0EYBOswqeTTPmrrEd/Tm6S8PhQHxgYdQ0qllgfd6H57hXklJ/b abq8vgNMb0WL22fop6pr7KlWJMcwtv/AyA== X-Google-Smtp-Source: AA6agR61boqv9R5GwxiSEbbbDiM7VdzQSGWRU8MnGks8DhasC46hZJmDN75uK7FdsIMuw+IzSjdDRA== X-Received: by 2002:a05:622a:2c4:b0:343:7f18:c2ab with SMTP id a4-20020a05622a02c400b003437f18c2abmr22347052qtx.641.1662027941508; Thu, 01 Sep 2022 03:25:41 -0700 (PDT) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com. [209.85.219.180]) by smtp.gmail.com with ESMTPSA id az20-20020a05620a171400b006bb41ac3b6bsm11672157qkb.113.2022.09.01.03.25.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 03:25:41 -0700 (PDT) Received: by mail-yb1-f180.google.com with SMTP id 21so7949618ybl.6; Thu, 01 Sep 2022 03:25:40 -0700 (PDT) X-Received: by 2002:a25:778d:0:b0:696:4bb6:9aaa with SMTP id s135-20020a25778d000000b006964bb69aaamr18315096ybc.380.1662027940511; Thu, 01 Sep 2022 03:25:40 -0700 (PDT) MIME-Version: 1.0 References: <20220830164518.1381632-1-biju.das.jz@bp.renesas.com> <20220830164518.1381632-2-biju.das.jz@bp.renesas.com> <23539312-caaa-78f0-cd6c-899a826f9947@linaro.org> <1ef5dbd4-806f-ac1d-0ad5-0f8359a560de@linaro.org> In-Reply-To: <1ef5dbd4-806f-ac1d-0ad5-0f8359a560de@linaro.org> From: Geert Uytterhoeven Date: Thu, 1 Sep 2022 12:25:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document RZ/N1 power-domains support To: Krzysztof Kozlowski Cc: Biju Das , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Tue, Aug 30, 2022 at 9:03 PM Krzysztof Kozlowski wrote: > On 30/08/2022 20:47, Biju Das wrote: > >> Subject: Re: [PATCH v3 1/3] dt-bindings: can: nxp,sja1000: Document > >> RZ/N1 power-domains support > >> > >> On 30/08/2022 19:45, Biju Das wrote: > >>> Document RZ/N1 power-domains support. Also update the example with > >>> power-domains property. > >>> > >>> Signed-off-by: Biju Das > >>> --- > >>> v3: > >>> * Documented power-domains support. > >> > >> You made them required, so it would be nice to see reason in such > >> change. The commit msg says only what you did, but not why you did it. > > > > It is simple. As you see from [1] and [2] power-domains are enabled by default in RZ/N1 SoC. > > So there is nothing prevent us to document this property for all IP's present in > > RZ/N1 SoC. > > Any explanation I expect to see in commit msg. > > Anyway you referred to Linux drivers, which is not actually a reason. > What if some device is not in a power domain? DT describes hardware, not software policy. "power domains" are a property of the hardware. I.e. this device (like most other devices on the SoC) is power-managed through the system-controller. Whether software does that by explicitly managing the clocks, or by having a PM Domains driver is a software detail. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds