From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367E3C636CA for ; Fri, 16 Jul 2021 19:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4A62613F8 for ; Fri, 16 Jul 2021 19:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229611AbhGPTMz (ORCPT ); Fri, 16 Jul 2021 15:12:55 -0400 Received: from mail-vs1-f42.google.com ([209.85.217.42]:37826 "EHLO mail-vs1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhGPTMy (ORCPT ); Fri, 16 Jul 2021 15:12:54 -0400 Received: by mail-vs1-f42.google.com with SMTP id r18so5630049vsa.4; Fri, 16 Jul 2021 12:09:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehJwWdmJnEqOFrEyqslwmNH6+ZDemUpg9Q/4BttkqCY=; b=AeookFuB5y6q7aP9LN+j7zbod4jXbumMxlFTdeCJc/C260j50Ls3bUioU/2mGD2LI/ ks0hRUGeheU7ie3RPeh0FQbFZcP4F75cDv2qsvjjzMozuFJZrommkgau532OcYOKHyjU 92kLYcbJL0ok6nF+TCzqQ3b3s0+wUiIP2WvHju/ir8hBKmitHvgju69WZO2PBYMkgDfK crhpUBIuEOzvrkBOhla75j1aEt6GhcWVGSHAc1WGyDV6lEbfL3rd5ZnwCXERRARpbuni mmHKC0ccg32ReGm8XLDwbaqIk5cSEBp/P5FVDsUE+8gZLE0jYNhWDHoxCN156jayB0wU 1tfA== X-Gm-Message-State: AOAM533B4IVVVioEMHBAndJJwhxmAhOWDaJUA/bdDJk8V4eT7l6+SqqK fUFNWqvqiTcFgQijOhPmbQYJ1xSIDRTGlmqyUUE= X-Google-Smtp-Source: ABdhPJxZ3GQdFZsnwGr4ysExj1rkCNjJYj/LMNp5Bwoi5+JuhzOdItSjtD8zznsMplgRv8d3nnp0PfgcVGSLfl6UM94= X-Received: by 2002:a67:3c2:: with SMTP id 185mr14494278vsd.42.1626462598688; Fri, 16 Jul 2021 12:09:58 -0700 (PDT) MIME-Version: 1.0 References: <20210716180253.GA3684196@robh.at.kernel.org> In-Reply-To: <20210716180253.GA3684196@robh.at.kernel.org> From: Geert Uytterhoeven Date: Fri, 16 Jul 2021 21:09:47 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements To: Rob Herring Cc: Krzysztof Kozlowski , Sergei Shtylyov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , linux-spi , MTD Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Fri, Jul 16, 2021 at 8:02 PM Rob Herring wrote: > On Wed, Jul 14, 2021 at 01:30:13PM +0200, Geert Uytterhoeven wrote: > > - Add missing "#{address,size}-cells", > > - Fix rejection of legitimate flash subnodes containing multiple > > compatible values, > > - Add missing list of required properties. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > .../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++--- > > 1 file changed, 20 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml > > index 990489fdd2ac33fe..c0d899a2305361b1 100644 > > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml > > @@ -56,17 +56,34 @@ properties: > > resets: > > maxItems: 1 > > > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > spi-controller.yaml already defines this. spi-controller.yaml says '#address-cells' must be 0 or 1. As RPC-IF does SPI master only, it should be 1. Don't remember why I added the '#size-cells' too. Perhaps for symmetry? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds