* [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements
@ 2021-07-14 11:30 Geert Uytterhoeven
2021-07-16 18:02 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 11:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Sergei Shtylyov
Cc: devicetree, linux-renesas-soc, linux-spi, linux-mtd, linux-kernel,
Geert Uytterhoeven
- Add missing "#{address,size}-cells",
- Fix rejection of legitimate flash subnodes containing multiple
compatible values,
- Add missing list of required properties.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
index 990489fdd2ac33fe..c0d899a2305361b1 100644
--- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
@@ -56,17 +56,34 @@ properties:
resets:
maxItems: 1
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
+
patternProperties:
"flash@[0-9a-f]+$":
type: object
properties:
compatible:
- enum:
- - cfi-flash
- - jedec,spi-nor
+ contains:
+ enum:
+ - cfi-flash
+ - jedec,spi-nor
unevaluatedProperties: false
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - power-domains
+ - resets
+ - '#address-cells'
+ - '#size-cells'
+
examples:
- |
#include <dt-bindings/clock/renesas-cpg-mssr.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements
2021-07-14 11:30 [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements Geert Uytterhoeven
@ 2021-07-16 18:02 ` Rob Herring
2021-07-16 19:09 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-07-16 18:02 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, Sergei Shtylyov, devicetree,
linux-renesas-soc, linux-spi, linux-mtd, linux-kernel
On Wed, Jul 14, 2021 at 01:30:13PM +0200, Geert Uytterhoeven wrote:
> - Add missing "#{address,size}-cells",
> - Fix rejection of legitimate flash subnodes containing multiple
> compatible values,
> - Add missing list of required properties.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> index 990489fdd2ac33fe..c0d899a2305361b1 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> @@ -56,17 +56,34 @@ properties:
> resets:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
spi-controller.yaml already defines this.
> patternProperties:
> "flash@[0-9a-f]+$":
> type: object
> properties:
> compatible:
> - enum:
> - - cfi-flash
> - - jedec,spi-nor
> + contains:
> + enum:
> + - cfi-flash
> + - jedec,spi-nor
>
> unevaluatedProperties: false
>
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - power-domains
> + - resets
> + - '#address-cells'
> + - '#size-cells'
> +
> examples:
> - |
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements
2021-07-16 18:02 ` Rob Herring
@ 2021-07-16 19:09 ` Geert Uytterhoeven
2021-07-20 16:42 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-07-16 19:09 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Sergei Shtylyov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, linux-spi, MTD Maling List,
Linux Kernel Mailing List
Hi Rob,
On Fri, Jul 16, 2021 at 8:02 PM Rob Herring <robh@kernel.org> wrote:
> On Wed, Jul 14, 2021 at 01:30:13PM +0200, Geert Uytterhoeven wrote:
> > - Add missing "#{address,size}-cells",
> > - Fix rejection of legitimate flash subnodes containing multiple
> > compatible values,
> > - Add missing list of required properties.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > .../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++---
> > 1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > index 990489fdd2ac33fe..c0d899a2305361b1 100644
> > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > @@ -56,17 +56,34 @@ properties:
> > resets:
> > maxItems: 1
> >
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
>
> spi-controller.yaml already defines this.
spi-controller.yaml says '#address-cells' must be 0 or 1. As RPC-IF does
SPI master only, it should be 1.
Don't remember why I added the '#size-cells' too. Perhaps for symmetry?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements
2021-07-16 19:09 ` Geert Uytterhoeven
@ 2021-07-20 16:42 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-07-20 16:42 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, Sergei Shtylyov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, linux-spi, MTD Maling List,
Linux Kernel Mailing List
On Fri, Jul 16, 2021 at 1:10 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Fri, Jul 16, 2021 at 8:02 PM Rob Herring <robh@kernel.org> wrote:
> > On Wed, Jul 14, 2021 at 01:30:13PM +0200, Geert Uytterhoeven wrote:
> > > - Add missing "#{address,size}-cells",
> > > - Fix rejection of legitimate flash subnodes containing multiple
> > > compatible values,
> > > - Add missing list of required properties.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > .../memory-controllers/renesas,rpc-if.yaml | 23 ++++++++++++++++---
> > > 1 file changed, 20 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > > index 990489fdd2ac33fe..c0d899a2305361b1 100644
> > > --- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > > +++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
> > > @@ -56,17 +56,34 @@ properties:
> > > resets:
> > > maxItems: 1
> > >
> > > + '#address-cells':
> > > + const: 1
> > > +
> > > + '#size-cells':
> > > + const: 0
> > > +
> >
> > spi-controller.yaml already defines this.
>
> spi-controller.yaml says '#address-cells' must be 0 or 1. As RPC-IF does
> SPI master only, it should be 1.
Yes, but then it says:
allOf:
- if:
not:
required:
- spi-slave
then:
properties:
"#address-cells":
const: 1
else:
properties:
"#address-cells":
const: 0
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-20 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14 11:30 [PATCH] dt-bindings: memory: renesas,rpc-if: Miscellaneous improvements Geert Uytterhoeven
2021-07-16 18:02 ` Rob Herring
2021-07-16 19:09 ` Geert Uytterhoeven
2021-07-20 16:42 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).