From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A369CC64E7A for ; Thu, 26 Nov 2020 13:39:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69C6022202 for ; Thu, 26 Nov 2020 13:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390575AbgKZNj1 (ORCPT ); Thu, 26 Nov 2020 08:39:27 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:45963 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390472AbgKZNj0 (ORCPT ); Thu, 26 Nov 2020 08:39:26 -0500 Received: by mail-ot1-f66.google.com with SMTP id k3so1867888otp.12; Thu, 26 Nov 2020 05:39:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EBEmuU91pYqLfQ3YGZGbk+yq54IRZktH6WhNjM47s9I=; b=tFIHTnEyqYiduRZ3ZvlVAofsOcU39W6Vd8uTy5xn6bH8LSXe0pdA2MNCnIn/QjSvvX Y/4OCUKBeWZblQAGz/YvkrnhIiWVy8SkH7DM+d6KJeGo4PBj7ywZTtw6H0KOsk2D//9E EduRpv45zqNbs++tJfNwk40yvkghr4Z4lAvr3wDc4NSVIVYLqtqbORULha+7zo4z/O2A Yy3bhA8HKUxDd681oy8UyoOPQW54ejWsxMNeBU5QCpcauiUzZGDKWG6EOoS3SM3ouA3e WuSmyHrvLiGTtaly2dcv94InuJccNzz09ebj7c6DqSsvAWuC2SdJCO0TEb6w0uktbVZB kskQ== X-Gm-Message-State: AOAM533gGx0EE3nS0/gnXzUTi3vvAAzwkeQCnvdGkjo0Nmk69E2hJgWY xI638a+kN3cGXFz8mhlg5LlbcTOQ4K/luutVj+A= X-Google-Smtp-Source: ABdhPJyQuVrEtrEM865mHm51prMFOdSEfEfHVcshVA+1GyxtMBdVjPX52mxFA8+Xfw/klNI/acrafaOcpwgnBGhU614= X-Received: by 2002:a9d:686:: with SMTP id 6mr1970874otx.107.1606397965198; Thu, 26 Nov 2020 05:39:25 -0800 (PST) MIME-Version: 1.0 References: <20201126103053.29881-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201126103053.29881-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20201126103053.29881-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 26 Nov 2020 14:39:14 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Separate out ov5640 nodes To: Lad Prabhakar Cc: Magnus Damm , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Biju Das , Prabhakar Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Prabhakar, On Thu, Nov 26, 2020 at 11:31 AM Lad Prabhakar wrote: > The camera daughter board can also be connected to 8-bit ov7725 sensors, > so in preparation for configurable option to choose depending on the > camera's connected separate out ov5640 nodes in a dtsi file. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Thanks for your patch! Reviewed-by: Geert Uytterhoeven However, I think this can still be improved upon. As it's a bit difficult to explain, I'll send an updated version of your series with my suggestions applied. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds