Re: [RFC] spi: Using Trigger number to transmit/receive data

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Hiep,

On Mon, Mar 17, 2014 at 1:01 PM, カオ　ミン　ヒェップ <cm-hiep@jinso.co.jp> wrote:
> On 03/17/2014 04:54 PM, Geert Uytterhoeven wrote:
>> On Mon, Mar 17, 2014 at 2:11 AM, カオ　ミン　ヒェップ <cm-hiep@jinso.co.jp> wrote:
>>> On 03/13/2014 06:23 PM, Geert Uytterhoeven wrote:
>>>> On Thu, Mar 13, 2014 at 9:29 AM, Cao Minh Hiep <cm-hiep@jinso.co.jp>
>>>> wrote:
>>>>> In order to transmit and receive data when have 32 bytes of data that
>>>>> ready has prepared on Transmit/Receive Buffer to transmit or receive.
>>>>> Instead transmits/receives a byte data using Transmit/Receive Buffer
>>>>> Data Triggering Number will improve the speed of transfer data.
>>>>
>>>> Thanks for your patch, this looks like a valuable improvement!
>>>>
>>>> Unfortunately your patch doesn't apply against spi/for-next anymore, as
>>>> the driver has changed a lot lately, due to the addition of RZ/A1H and
>>>> Quad/Dual support.
>>>>
>>> Thanks, Do you mean this patch did not need for next and I don't mind
>>> about
>>> it?
>>
>> It means you will have to rework your patch to apply on top of
>>
>> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/tree/drivers/spi?h=for-next
>> before the SPI maintainer can accept it.
>
> Thanks, I understood, I will rework my patch and report to your later.

I gave your patch a try on a v3.14-rc5 kernel on r8a7791/Koelsch,
and it increased Single SPI read transfer speed from ca. 1 Mbps to 11 Mbps.
So I'm looking forward to an updated version.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds