From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [RFC] spi: Using Trigger number to transmit/receive data Date: Mon, 17 Mar 2014 20:48:43 +0100 Message-ID: References: <1394699364-5669-1-git-send-email-cm-hiep@jinso.co.jp> <1394699364-5669-2-git-send-email-cm-hiep@jinso.co.jp> <53264BA4.3000401@jinso.co.jp> <5326E424.9040709@jinso.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5326E424.9040709@jinso.co.jp> Sender: linux-sh-owner@vger.kernel.org To: Cao Minh Hiep Cc: Mark Brown , "devicetree@vger.kernel.org" , Linux-sh list , Kuninori Morimoto , Geert Uytterhoeven List-Id: devicetree@vger.kernel.org Hi Hiep, On Mon, Mar 17, 2014 at 1:01 PM, =E3=82=AB=E3=82=AA=E3=80=80=E3=83=9F=E3= =83=B3=E3=80=80=E3=83=92=E3=82=A7=E3=83=83=E3=83=97 wrote: > On 03/17/2014 04:54 PM, Geert Uytterhoeven wrote: >> On Mon, Mar 17, 2014 at 2:11 AM, =E3=82=AB=E3=82=AA=E3=80=80=E3=83=9F= =E3=83=B3=E3=80=80=E3=83=92=E3=82=A7=E3=83=83=E3=83=97 wrote: >>> On 03/13/2014 06:23 PM, Geert Uytterhoeven wrote: >>>> On Thu, Mar 13, 2014 at 9:29 AM, Cao Minh Hiep >>>> wrote: >>>>> In order to transmit and receive data when have 32 bytes of data = that >>>>> ready has prepared on Transmit/Receive Buffer to transmit or rece= ive. >>>>> Instead transmits/receives a byte data using Transmit/Receive Buf= fer >>>>> Data Triggering Number will improve the speed of transfer data. >>>> >>>> Thanks for your patch, this looks like a valuable improvement! >>>> >>>> Unfortunately your patch doesn't apply against spi/for-next anymor= e, as >>>> the driver has changed a lot lately, due to the addition of RZ/A1H= and >>>> Quad/Dual support. >>>> >>> Thanks, Do you mean this patch did not need for next and I don't mi= nd >>> about >>> it? >> >> It means you will have to rework your patch to apply on top of >> >> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/tree/dr= ivers/spi?h=3Dfor-next >> before the SPI maintainer can accept it. > > Thanks, I understood, I will rework my patch and report to your later= =2E I gave your patch a try on a v3.14-rc5 kernel on r8a7791/Koelsch, and it increased Single SPI read transfer speed from ca. 1 Mbps to 11 M= bps. So I'm looking forward to an updated version. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. -- Linus Torvalds