From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: Bad DT binding (hisi-pcie-almost-ecam) Date: Mon, 13 Mar 2017 09:48:51 +0100 Message-ID: References: <20170310174045.GB24571@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gabriele Paoloni Cc: Mark Rutland , "liudongdong (C)" , Bjorn Helgaas , "Wangzhou (B)" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Mar 13, 2017 at 9:14 AM, Gabriele Paoloni wrote: > About the name to use here from what you suggest we should use > "hisilicon,hip06-pcie-almost-ecam" and re-use it for hip07 SoC. > To be honest I would prefer it either as it is now or to modify the > driver as: > > diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c > index 52f1e3f..7527b4c 100644 > --- a/drivers/pci/dwc/pcie-hisi.c > +++ b/drivers/pci/dwc/pcie-hisi.c > @@ -381,7 +381,11 @@ struct pci_ecam_ops hisi_pcie_platform_ops = { > > static const struct of_device_id hisi_pcie_almost_ecam_of_match[] = { > { > - .compatible = "hisilicon,pcie-almost-ecam", > + .compatible = "hisilicon,pcie-almost-ecam-hip06", Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"? > + .data = (void *) &hisi_pcie_platform_ops, > + }, > + { > + .compatible = "hisilicon,pcie-almost-ecam-hip07", Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"? > .data = (void *) &hisi_pcie_platform_ops, > }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html