From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E29C433FE for ; Thu, 28 Apr 2022 10:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233129AbiD1KDo convert rfc822-to-8bit (ORCPT ); Thu, 28 Apr 2022 06:03:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbiD1KDH (ORCPT ); Thu, 28 Apr 2022 06:03:07 -0400 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE7BDB6469; Thu, 28 Apr 2022 02:49:42 -0700 (PDT) Received: by mail-qk1-f170.google.com with SMTP id e128so3167366qkd.7; Thu, 28 Apr 2022 02:49:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WDmfPpadZf0LBFbdDJYdxQ5ahsqbbrqVM35oCxvqkdU=; b=QRLIGin6HvtekZfg3fQ0LDqqEBawaEnOLMqRB1OCg/oStzxRH7zX7rr9IT264MyFeR /APy8eq4UB0w4WvVoP9G/cTFNjCx5TVzaGY4eJCkuXGpUzhahIcdwYJAMLqiEFZFVw4P c+dnz4DWeapZ3mqRDLdRn7wd6t+owcuL9W8oX7W/oHbONYaXpOp4wAErtqOLmObWYRF5 Q23gGzZHolU5q1j8h5RAqyDCksU8Wv+FpxY+fM0HAeiTV24sBNtN74GbXuDJRWFyO2Kb 44AID8aObrAPSUY621a9UQ0DsWV9aIpBw6JgSkXWI1Vx0dZsoUr4FDHYZn5wtMpukRN9 0qTA== X-Gm-Message-State: AOAM533gZMxvJHzLQ7s9v1d3gIy+rF42EyZIy5vQS8l/VUw1G8ZavwJe L80RR7eJRU7UfIJD8hWFmeoWeehWuV4msg== X-Google-Smtp-Source: ABdhPJzEgp776Kf5FOKXJ1wlPqwsx9CFCvBqF0vZwU9mVicqmEv42VOJUhleQanhAYqWL2PhOfeCHA== X-Received: by 2002:a05:620a:1981:b0:507:4a52:f310 with SMTP id bm1-20020a05620a198100b005074a52f310mr19186194qkb.611.1651139381708; Thu, 28 Apr 2022 02:49:41 -0700 (PDT) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com. [209.85.128.173]) by smtp.gmail.com with ESMTPSA id r83-20020a37a856000000b0069ed4436a49sm9458658qke.87.2022.04.28.02.49.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 02:49:41 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2f7ca2ce255so46509367b3.7; Thu, 28 Apr 2022 02:49:41 -0700 (PDT) X-Received: by 2002:a81:1cd5:0:b0:2f4:c3fc:2174 with SMTP id c204-20020a811cd5000000b002f4c3fc2174mr32391381ywc.512.1651139380892; Thu, 28 Apr 2022 02:49:40 -0700 (PDT) MIME-Version: 1.0 References: <20220422120850.769480-1-herve.codina@bootlin.com> <20220422120850.769480-7-herve.codina@bootlin.com> In-Reply-To: <20220422120850.769480-7-herve.codina@bootlin.com> From: Geert Uytterhoeven Date: Thu, 28 Apr 2022 11:49:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 6/8] ARM: dts: r9a06g032: Add internal PCI bridge node To: Herve Codina Cc: Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Magnus Damm , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Hervé On Fri, Apr 22, 2022 at 2:09 PM Herve Codina wrote: > Add the device node for the r9a06g032 internal PCI bridge device. > > Signed-off-by: Herve Codina Thanks for your patch! > --- a/arch/arm/boot/dts/r9a06g032.dtsi > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > @@ -212,6 +212,35 @@ gic: interrupt-controller@44101000 { > interrupts = > ; > }; > + > + pci_usb: pci@40030000 { > + compatible = "renesas,pci-r9a06g032", "renesas,pci-rzn1"; > + device_type = "pci"; > + clocks = <&sysctrl R9A06G032_HCLK_USBH>, > + <&sysctrl R9A06G032_HCLK_USBPM>, > + <&sysctrl R9A06G032_CLK_PCI_USB>; > + clock-names = "hclk_usbh", "hclk_usbpm", "clk_pci_usb"; The clock names need an update, cfr. my comment on the bindings. The rest LGTM, so with the above fixed: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds