From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Date: Fri, 23 Feb 2018 08:06:11 +0100 Message-ID: References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> <20180221182340.wvdvgtv5pw7pvd3v@verge.net.au> <20180222155411.gnn42poawtlf3rze@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180222155411.gnn42poawtlf3rze@verge.net.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , jacopo mondi , Sergei Shtylyov , Magnus Damm , Linux Kernel Mailing List , Linux-Renesas , Rob Herring , Jacopo Mondi , Linux ARM List-Id: devicetree@vger.kernel.org Hi Simon, On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman wrote: > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote: >> On 02/21/2018 09:23 PM, Simon Horman wrote: >> >> > ... >> > >> >>>>>>>> + clocks = <&cpg CPG_MOD 812>; >> >>>>>>>> + power-domains = <&sysc 32>; >> >>>>>>>> + resets = <&cpg 812>; >> >>>>>>>> + phy-mode = "rgmii-txid"; >> >>>>>>> >> >>>>>>> Why not just "rgmii"? TX delay is a board specific detail, no? >> >>>>>>> >> >>>>>> I admit I took this one straight from r8a7796 dtsi. >> >>>>>> Would you like to me resend and change this? >> >>>>> >> >>>>> Yes, unless Simon would fix it while merging... >> >>>> >> >>>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? >> >>> >> >>> Yes. >> >> >> >> Apparently that means that this prop should be overridden in the board file >> >> (which may not be an easy task given the board is Salvator-XS again). >> >> >> >> [...] >> > >> > Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts? >> >> In salvator-common.dtsi most probably -- it has the PHY data for Ether AVB. >> >> > I feel that I'm missing an important point here. >> >> Well, r8a779{5|6}.dtsi also have phy-mode = "rgmii-txid" (which was >> unjustified in my current understanding). Thus such board override >> wouldn't hurt them. But we lack a patch modifying salvator-common.dtsi >> in htis series, so I'm now thinking a respin of this series is needed >> anyway... sorry for being unclear. :-) > > While I've applied other patches in this series I have > not applied this one - mainly to allow this discussion to conclude. > > Is an appropriate solution to do the following? > > 1) Atomically update > a) r8a779{5|6}.dtsi to use "rgmii" and > b) salvator-common.dtsi to use "rgmii-txid" > 2) Update this patch to use "rgmii" No need for atomics. It can all be done by patches touching single files only: 1) Add "rgmii-txid" to board .dts(i) files, 2) Change s/rgmii-txid/rgmii/ in SoC .dtsi files. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds