From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 1/4] of/device: Add a way to probe drivers by match data Date: Fri, 9 Nov 2018 11:36:17 +0100 Message-ID: References: <20181106183609.207702-1-sboyd@kernel.org> <20181106183609.207702-2-sboyd@kernel.org> <154169993998.88331.10494065577891939152@swboyd.mtv.corp.google.com> <0f2bb386-ba92-544c-e980-c95309944b22@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <0f2bb386-ba92-544c-e980-c95309944b22@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger Cc: Stephen Boyd , Michael Turquette , Linux Kernel Mailing List , Linux ARM , linux-clk , linux-mediatek@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ryder.lee@mediatek.com, Rob Herring , Frank Rowand List-Id: devicetree@vger.kernel.org Hi Matthias, On Fri, Nov 9, 2018 at 11:29 AM Matthias Brugger wrote: > On 08/11/2018 18:58, Stephen Boyd wrote: > > Quoting Matthias Brugger (2018-11-08 00:29:46) > >> On 06/11/2018 19:36, Stephen Boyd wrote: > >>> +int platform_driver_probe_by_of_match_data(struct platform_device *pdev) > >>> +{ > >>> + int (*probe_func)(struct platform_device *pdev); > >>> + > >>> + probe_func = of_device_get_match_data(&pdev->dev); > >> > >> Shouldn't we check if probe_func is not NULL? > > > > Is the oops from the NULL pointer deref insufficient? > > Do you think we should crash the machine if someone uses the call wrongly? Or > should we provide the possibility to error out on the caller side? I believe that would be a bug in the driver, to be discovered ASAP. So yes, please do crash ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds