devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding
Date: Mon, 6 Oct 2025 17:48:58 +0200	[thread overview]
Message-ID: <CAMuHMdX-arzDXgv-2gUs8uAt_APkoM3VnAvAYbp1N8oc2v84Hw@mail.gmail.com> (raw)
In-Reply-To: <20251003215318.39757-1-niklas.soderlund+renesas@ragnatech.se>

Hi Niklas,

On Fri, 3 Oct 2025 at 23:53, Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Use the more modern adi,adv7180cp compatible for the CVBS input found on
> R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
> board with the same setup Gose.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> @@ -295,6 +295,16 @@ hdmi_con_in: endpoint {
>                 };
>         };
>
> +       composite-in {
> +               compatible = "composite-video-connector";
> +
> +               port {
> +                       composite_con_in: endpoint {
> +                               remote-endpoint = <&adv7180_in>;
> +                       };
> +               };
> +       };
> +

Moving this below cec-clock while applying, to "preserve" (sic) sort order...

>         cec_clock: cec-clock {
>                 compatible = "fixed-clock";
>                 #clock-cells = <0>;

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      parent reply	other threads:[~2025-10-06 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-03 21:53 [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding Niklas Söderlund
2025-10-06  6:49 ` Wolfram Sang
2025-10-06  8:16   ` Niklas Söderlund
2025-10-06 15:47   ` Geert Uytterhoeven
2025-10-06 15:48 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdX-arzDXgv-2gUs8uAt_APkoM3VnAvAYbp1N8oc2v84Hw@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).