[PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[Niklas Söderlund]

Use the more modern adi,adv7180cp compatible for the CVBS input found on
R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
board with the same setup Gose.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm/boot/dts/renesas/r8a7791-koelsch.dts | 34 +++++++++++++++----
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
index e9f90fa44d55..9c97215a7039 100644
--- a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
@@ -295,6 +295,16 @@ hdmi_con_in: endpoint {
 		};
 	};
 
+	composite-in {
+		compatible = "composite-video-connector";
+
+		port {
+			composite_con_in: endpoint {
+				remote-endpoint = <&adv7180_in>;
+			};
+		};
+	};
+
 	cec_clock: cec-clock {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
@@ -383,13 +393,25 @@ ak4643: codec@12 {
 		};
 
 		composite-in@20 {
-			compatible = "adi,adv7180";
+			compatible = "adi,adv7180cp";
 			reg = <0x20>;
 
-			port {
-				adv7180: endpoint {
-					bus-width = <8>;
-					remote-endpoint = <&vin1ep>;
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					adv7180_in: endpoint {
+						remote-endpoint = <&composite_con_in>;
+					};
+				};
+
+				port@3 {
+					reg = <3>;
+					adv7180_out: endpoint {
+						remote-endpoint = <&vin1ep>;
+					};
 				};
 			};
 		};
@@ -900,7 +922,7 @@ &vin1 {
 
 	port {
 		vin1ep: endpoint {
-			remote-endpoint = <&adv7180>;
+			remote-endpoint = <&adv7180_out>;
 			bus-width = <8>;
 		};
 	};
-- 
2.51.0

Re: [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On Fri, Oct 03, 2025 at 11:53:18PM +0200, Niklas Söderlund wrote:
> Use the more modern adi,adv7180cp compatible for the CVBS input found on
> R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
> board with the same setup Gose.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

I think this could be added?

Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[Niklas Söderlund]

On 2025-10-06 08:49:28 +0200, Wolfram Sang wrote:
> On Fri, Oct 03, 2025 at 11:53:18PM +0200, Niklas Söderlund wrote:
> > Use the more modern adi,adv7180cp compatible for the CVBS input found on
> > R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
> > board with the same setup Gose.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> I think this could be added?
> 
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 

Good point, sorry for forgetting it.


-- 
Kind Regards,
Niklas Söderlund

Re: [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, 6 Oct 2025 at 08:49, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Fri, Oct 03, 2025 at 11:53:18PM +0200, Niklas Söderlund wrote:
> > Use the more modern adi,adv7180cp compatible for the CVBS input found on
> > R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
> > board with the same setup Gose.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> I think this could be added?
>
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>

I don't think I am the first one suggesting that ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: dts: renesas: koelsch: Update ADV7180 binding

[Geert Uytterhoeven]

Hi Niklas,

On Fri, 3 Oct 2025 at 23:53, Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Use the more modern adi,adv7180cp compatible for the CVBS input found on
> R-Car Gen2 Koelsch boards. This aligns the bindings with the other Gen2
> board with the same setup Gose.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> @@ -295,6 +295,16 @@ hdmi_con_in: endpoint {
>                 };
>         };
>
> +       composite-in {
> +               compatible = "composite-video-connector";
> +
> +               port {
> +                       composite_con_in: endpoint {
> +                               remote-endpoint = <&adv7180_in>;
> +                       };
> +               };
> +       };
> +

Moving this below cec-clock while applying, to "preserve" (sic) sort order...

>         cec_clock: cec-clock {
>                 compatible = "fixed-clock";
>                 #clock-cells = <0>;

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.19.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds