From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string
Date: Fri, 4 Nov 2022 09:55:30 +0100 [thread overview]
Message-ID: <CAMuHMdX-b-DoNGeccO82bh4s9d7HKh_7o5W967a_iKBMo-fckw@mail.gmail.com> (raw)
In-Reply-To: <7fcd798a-9cce-9453-1657-7be1abf3b97e@linaro.org>
Hi Krzysztof,
On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 03/11/2022 19:06, Fabrizio Castro wrote:
> > s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> >
> > renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> > changing this doesn't cause any harm.
>
> And what about other users of DTS? One chosen driver implementation
> might not be enough...
>
> >
> > Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
>
> You need to explain the bug - where is the issue, how it affects users.
> Otherwise it is not a bug and there is nothing to fix.
Yep.
The preferred form is "<vendor>,<family>-<module>", blah blah ...
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> > Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > index c46378efc123..92e899905ef8 100644
> > --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > @@ -16,7 +16,7 @@ properties:
> > compatible:
> > items:
> > - enum:
> > - - renesas,i2c-r9a09g011 # RZ/V2M
> > + - renesas,r9a09g011-i2c # RZ/V2M
>
> No.
>
> Deprecate instead old compatible. There are already users of it, at
> least in kernel. Not sure about other OS/bootloaders/firmwares.
As stated in the cover letter:
Since it's early days for r9a09g011.dtsi, and compatible
renesas,i2c-r9a09g011 isn't being actively used at the moment,
I think it's safe to change to make compatible strings less
confusing.
The bindings entered in v6.0.
The first user in the kernel is not yet in a released kernel, it will
be in v6.1. So it can still be fixed in v6.1...
Even if we don't fix it before v6.2, I don't think there is much harm in
making this change.
With the patch description improved:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-11-04 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 23:06 [PATCH 0/3] Minor fixes for RZ/V2M Fabrizio Castro
2022-11-03 23:06 ` [PATCH 1/3] arm64: dts: renesas: r9a09g011: Fix unit address format error Fabrizio Castro
2022-11-04 8:46 ` Geert Uytterhoeven
2022-11-03 23:06 ` [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string Fabrizio Castro
2022-11-04 1:48 ` Krzysztof Kozlowski
2022-11-04 8:55 ` Geert Uytterhoeven [this message]
2022-11-04 12:55 ` Krzysztof Kozlowski
2022-11-07 16:46 ` Fabrizio Castro
2022-11-03 23:06 ` [PATCH 3/3] arm64: dts: renesas: r9a09g011: Fix I2C SoC specific strings Fabrizio Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX-b-DoNGeccO82bh4s9d7HKh_7o5W967a_iKBMo-fckw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).