devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] arm64: dts: renesas: draak: Make HDMI default video source
@ 2023-10-22 18:19 Niklas Söderlund
  2023-10-22 18:19 ` [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund
  2023-10-22 18:19 ` [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node Niklas Söderlund
  0 siblings, 2 replies; 5+ messages in thread
From: Niklas Söderlund @ 2023-10-22 18:19 UTC (permalink / raw)
  To: Geert Uytterhoeven, devicetree; +Cc: linux-renesas-soc, Niklas Söderlund

Hello,

This series makes aligns the Draak board with other Gen3 boards by
making the HDMI video source the default video input.

Patch 1/2 changes the default, while patch 2/2 moves the bus properties 
to the correct node so they can be consumed by the capture driver.

Niklas Söderlund (2):
  arm64: dts: renesas: draak: Make HDMI the default video input
  arm64: dts: renesas: draak: Move HDMI bus properties to correct node

 arch/arm64/boot/dts/renesas/draak.dtsi | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

-- 
2.42.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input
  2023-10-22 18:19 [PATCH v2 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund
@ 2023-10-22 18:19 ` Niklas Söderlund
  2023-11-21  8:51   ` Geert Uytterhoeven
  2023-10-22 18:19 ` [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node Niklas Söderlund
  1 sibling, 1 reply; 5+ messages in thread
From: Niklas Söderlund @ 2023-10-22 18:19 UTC (permalink / raw)
  To: Geert Uytterhoeven, devicetree; +Cc: linux-renesas-soc, Niklas Söderlund

Most Gen3 R-Car devices have HDMI as the default video input source,
align Draak with them and make HDMI the default.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
* Changes since v1
- Split moving the incorrect bus properties to separate patch.
---
 arch/arm64/boot/dts/renesas/draak.dtsi | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
index ef3bb835d5c0..08b3458a5025 100644
--- a/arch/arm64/boot/dts/renesas/draak.dtsi
+++ b/arch/arm64/boot/dts/renesas/draak.dtsi
@@ -356,12 +356,9 @@ port@3 {
 				 * CVBS and HDMI inputs through SW[49-53]
 				 * switches.
 				 *
-				 * CVBS is the default selection, link it to
-				 * VIN4 here.
+				 * HDMI is the default selection, leave CVBS
+				 * not connected here.
 				 */
-				adv7180_out: endpoint {
-					remote-endpoint = <&vin4_in>;
-				};
 			};
 		};
 
@@ -423,13 +420,14 @@ port@2 {
 				 * CVBS and HDMI inputs through SW[49-53]
 				 * switches.
 				 *
-				 * CVBS is the default selection, leave HDMI
-				 * not connected here.
+				 * HDMI is the default selection, link it to
+				 * VIN4 here.
 				 */
 				adv7612_out: endpoint {
 					pclk-sample = <0>;
 					hsync-active = <0>;
 					vsync-active = <0>;
+					remote-endpoint = <&vin4_in>;
 				};
 			};
 		};
@@ -580,8 +578,8 @@ usb0_pins: usb0 {
 		function = "usb0";
 	};
 
-	vin4_pins_cvbs: vin4 {
-		groups = "vin4_data8", "vin4_sync", "vin4_clk";
+	vin4_pins: vin4 {
+		groups = "vin4_data24", "vin4_sync", "vin4_clk";
 		function = "vin4";
 	};
 };
@@ -729,7 +727,7 @@ &usb2_phy0 {
 };
 
 &vin4 {
-	pinctrl-0 = <&vin4_pins_cvbs>;
+	pinctrl-0 = <&vin4_pins>;
 	pinctrl-names = "default";
 
 	status = "okay";
@@ -737,7 +735,7 @@ &vin4 {
 	ports {
 		port {
 			vin4_in: endpoint {
-				remote-endpoint = <&adv7180_out>;
+				remote-endpoint = <&adv7612_out>;
 			};
 		};
 	};
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node
  2023-10-22 18:19 [PATCH v2 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund
  2023-10-22 18:19 ` [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund
@ 2023-10-22 18:19 ` Niklas Söderlund
  2023-11-21  8:52   ` Geert Uytterhoeven
  1 sibling, 1 reply; 5+ messages in thread
From: Niklas Söderlund @ 2023-10-22 18:19 UTC (permalink / raw)
  To: Geert Uytterhoeven, devicetree; +Cc: linux-renesas-soc, Niklas Söderlund

The bus properties for HDMI capture are defined on the incorrect node
for the VIN driver to be able to consume them. They are described on the
HDMI video source but they should be described on the VIN capture node,
move them.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm64/boot/dts/renesas/draak.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
index 08b3458a5025..953d1bb98f9d 100644
--- a/arch/arm64/boot/dts/renesas/draak.dtsi
+++ b/arch/arm64/boot/dts/renesas/draak.dtsi
@@ -424,9 +424,6 @@ port@2 {
 				 * VIN4 here.
 				 */
 				adv7612_out: endpoint {
-					pclk-sample = <0>;
-					hsync-active = <0>;
-					vsync-active = <0>;
 					remote-endpoint = <&vin4_in>;
 				};
 			};
@@ -735,6 +732,9 @@ &vin4 {
 	ports {
 		port {
 			vin4_in: endpoint {
+				pclk-sample = <0>;
+				hsync-active = <0>;
+				vsync-active = <0>;
 				remote-endpoint = <&adv7612_out>;
 			};
 		};
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input
  2023-10-22 18:19 ` [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund
@ 2023-11-21  8:51   ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-11-21  8:51 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: devicetree, linux-renesas-soc

On Sun, Oct 22, 2023 at 8:19 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Most Gen3 R-Car devices have HDMI as the default video input source,
> align Draak with them and make HDMI the default.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v1
> - Split moving the incorrect bus properties to separate patch.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node
  2023-10-22 18:19 ` [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node Niklas Söderlund
@ 2023-11-21  8:52   ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-11-21  8:52 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: devicetree, linux-renesas-soc

On Sun, Oct 22, 2023 at 8:19 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The bus properties for HDMI capture are defined on the incorrect node
> for the VIN driver to be able to consume them. They are described on the
> HDMI video source but they should be described on the VIN capture node,
> move them.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-11-21  8:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-22 18:19 [PATCH v2 0/2] arm64: dts: renesas: draak: Make HDMI default video source Niklas Söderlund
2023-10-22 18:19 ` [PATCH v2 1/2] arm64: dts: renesas: draak: Make HDMI the default video input Niklas Söderlund
2023-11-21  8:51   ` Geert Uytterhoeven
2023-10-22 18:19 ` [PATCH v2 2/2] arm64: dts: renesas: draak: Move HDMI bus properties to correct node Niklas Söderlund
2023-11-21  8:52   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).